Re: [PATCH v5] hw/i386/cpu: remove default_cpu_version and simplify

2025-01-24 Thread Ani Sinha
On Thu, Jan 23, 2025 at 7:52 PM Igor Mammedov wrote: > > On Thu, 23 Jan 2025 17:26:12 +0530 > Ani Sinha wrote: > > > commit 0788a56bd1ae3 ("i386: Make unversioned CPU models be aliases") > > introduced 'default_cpu_version' for PCMachineClass. This created three > > categories of CPU models: > >

Re: [PATCH v5] hw/i386/cpu: remove default_cpu_version and simplify

2025-01-23 Thread Igor Mammedov
On Thu, 23 Jan 2025 17:26:12 +0530 Ani Sinha wrote: > commit 0788a56bd1ae3 ("i386: Make unversioned CPU models be aliases") > introduced 'default_cpu_version' for PCMachineClass. This created three > categories of CPU models: > - Most unversioned CPU models would use version 1 by default. > - F

Re: [PATCH v5] hw/i386/cpu: remove default_cpu_version and simplify

2025-01-23 Thread Zhao Liu
> hw/i386/microvm.c | 3 +- > hw/i386/pc.c | 14 + > hw/i386/pc_piix.c | 6 ++-- > hw/i386/pc_q35.c | 6 ++-- > hw/i386/x86-common.c | 4 +-- > include/hw/i386/pc.h | 7 +++-- > include/hw/i386/x86.h | 2 +- > target/i386/cpu.c | 69 ++-

[PATCH v5] hw/i386/cpu: remove default_cpu_version and simplify

2025-01-23 Thread Ani Sinha
commit 0788a56bd1ae3 ("i386: Make unversioned CPU models be aliases") introduced 'default_cpu_version' for PCMachineClass. This created three categories of CPU models: - Most unversioned CPU models would use version 1 by default. - For machines 4.0.1 and older that do not support cpu model aliase