Re: [PATCH v4 8/9] qapi: make 'if' condition strings simple identifiers

2021-05-21 Thread Markus Armbruster
Marc-André Lureau writes: > On Fri, May 21, 2021 at 4:03 PM Markus Armbruster wrote: [...] >> At this point in your series, the documentation does not yet reflect the >> code changes you've made. You now add another change together with a >> doc update. Now the docs match *no* version of the

Re: [PATCH v4 8/9] qapi: make 'if' condition strings simple identifiers

2021-05-21 Thread Marc-André Lureau
On Fri, May 21, 2021 at 4:03 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Change the 'if' condition strings to be C-agnostic and be simple > > identifiers. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Stefan Hajnoczi > > T

Re: [PATCH v4 8/9] qapi: make 'if' condition strings simple identifiers

2021-05-21 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Change the 'if' condition strings to be C-agnostic and be simple > identifiers. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Stefan Hajnoczi > Tested-by: John Snow > --- [...] > diff --git a/docs/devel/qapi-code-gen.txt

[PATCH v4 8/9] qapi: make 'if' condition strings simple identifiers

2021-05-17 Thread marcandre . lureau
From: Marc-André Lureau Change the 'if' condition strings to be C-agnostic and be simple identifiers. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi Tested-by: John Snow --- docs/devel/qapi-code-gen.txt | 8 +-- qapi/block-core.json |