Re: [PATCH v4 7/7] crypto: Make QCryptoTLSCreds* structures private

2021-06-17 Thread Daniel P . Berrangé
On Thu, Jun 17, 2021 at 02:08:17PM +0200, Philippe Mathieu-Daudé wrote: > On 6/17/21 11:35 AM, Daniel P. Berrangé wrote: > > On Wed, Jun 16, 2021 at 06:22:25PM +0200, Philippe Mathieu-Daudé wrote: > >> Code consuming the "crypto/tlscreds*.h" APIs doesn't need > >> to access its internals. Move the

Re: [PATCH v4 7/7] crypto: Make QCryptoTLSCreds* structures private

2021-06-17 Thread Philippe Mathieu-Daudé
On 6/17/21 11:35 AM, Daniel P. Berrangé wrote: > On Wed, Jun 16, 2021 at 06:22:25PM +0200, Philippe Mathieu-Daudé wrote: >> Code consuming the "crypto/tlscreds*.h" APIs doesn't need >> to access its internals. Move the structure definitions to >> the "tlscredspriv.h" private header (only accessible

Re: [PATCH v4 7/7] crypto: Make QCryptoTLSCreds* structures private

2021-06-17 Thread Daniel P . Berrangé
On Wed, Jun 16, 2021 at 06:22:25PM +0200, Philippe Mathieu-Daudé wrote: > Code consuming the "crypto/tlscreds*.h" APIs doesn't need > to access its internals. Move the structure definitions to > the "tlscredspriv.h" private header (only accessible by > implementations). The public headers (in inclu

[PATCH v4 7/7] crypto: Make QCryptoTLSCreds* structures private

2021-06-16 Thread Philippe Mathieu-Daudé
Code consuming the "crypto/tlscreds*.h" APIs doesn't need to access its internals. Move the structure definitions to the "tlscredspriv.h" private header (only accessible by implementations). The public headers (in include/) still forward-declare the structures typedef. This solves a bug introduced