Re: [PATCH v4 6/9] spapr_pci: add spapr msi read method

2020-08-11 Thread P J P
+-- On Tue, 11 Aug 2020, Philippe Mathieu-Daudé wrote --+ | Cc'ing PCI maintainers ... | > +.read = spapr_msi_read, | | Shouldn't this be a read_with_attrs handler returning MEMTX_ERROR | instead? Maybe we need another MemTxResult which does not yet exist. Could this be a subsequent new patch

Re: [PATCH v4 6/9] spapr_pci: add spapr msi read method

2020-08-11 Thread Philippe Mathieu-Daudé
Cc'ing PCI maintainers On 8/11/20 1:41 PM, P J P wrote: > From: Prasad J Pandit > > Add spapr msi mmio read method to avoid NULL pointer dereference > issue. > > Reported-by: Lei Sun > Acked-by: David Gibson > Reviewed-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/ppc/spapr_pci.

[PATCH v4 6/9] spapr_pci: add spapr msi read method

2020-08-11 Thread P J P
From: Prasad J Pandit Add spapr msi mmio read method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Acked-by: David Gibson Reviewed-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/ppc/spapr_pci.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Update