Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-30 Thread Akihiko Odaki
On 2024/08/31 0:05, Peter Xu wrote: On Fri, Aug 30, 2024 at 03:11:38PM +0900, Akihiko Odaki wrote: On 2024/08/30 4:48, Peter Xu wrote: On Thu, Aug 29, 2024 at 01:39:36PM +0900, Akihiko Odaki wrote: I am calling the fact that embedded memory regions are accessible in instance_finalize() "live".

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-30 Thread Peter Xu
On Fri, Aug 30, 2024 at 03:11:38PM +0900, Akihiko Odaki wrote: > On 2024/08/30 4:48, Peter Xu wrote: > > On Thu, Aug 29, 2024 at 01:39:36PM +0900, Akihiko Odaki wrote: > > > > > I am calling the fact that embedded memory regions are accessible in > > > > > instance_finalize() "live". A device can p

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-29 Thread Akihiko Odaki
On 2024/08/30 4:48, Peter Xu wrote: On Thu, Aug 29, 2024 at 01:39:36PM +0900, Akihiko Odaki wrote: I am calling the fact that embedded memory regions are accessible in instance_finalize() "live". A device can perform operations on its memory regions during instance_finalize() and we should be aw

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-29 Thread Peter Xu
On Thu, Aug 29, 2024 at 01:39:36PM +0900, Akihiko Odaki wrote: > > > I am calling the fact that embedded memory regions are accessible in > > > instance_finalize() "live". A device can perform operations on its memory > > > regions during instance_finalize() and we should be aware of that. > > > >

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-28 Thread Akihiko Odaki
On 2024/08/29 0:56, Peter Xu wrote: On Wed, Aug 28, 2024 at 11:02:06PM +0900, Akihiko Odaki wrote: On 2024/08/28 22:09, Peter Xu wrote: On Wed, Aug 28, 2024 at 02:33:59PM +0900, Akihiko Odaki wrote: On 2024/08/28 1:11, Peter Xu wrote: On Tue, Aug 27, 2024 at 01:14:51PM +0900, Akihiko Odaki wr

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-28 Thread Peter Xu
On Wed, Aug 28, 2024 at 11:02:06PM +0900, Akihiko Odaki wrote: > On 2024/08/28 22:09, Peter Xu wrote: > > On Wed, Aug 28, 2024 at 02:33:59PM +0900, Akihiko Odaki wrote: > > > On 2024/08/28 1:11, Peter Xu wrote: > > > > On Tue, Aug 27, 2024 at 01:14:51PM +0900, Akihiko Odaki wrote: > > > > > On 2024

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-28 Thread Akihiko Odaki
On 2024/08/28 22:09, Peter Xu wrote: On Wed, Aug 28, 2024 at 02:33:59PM +0900, Akihiko Odaki wrote: On 2024/08/28 1:11, Peter Xu wrote: On Tue, Aug 27, 2024 at 01:14:51PM +0900, Akihiko Odaki wrote: On 2024/08/27 4:42, Peter Xu wrote: On Mon, Aug 26, 2024 at 06:10:25PM +0100, Peter Maydell wr

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-28 Thread Peter Xu
On Wed, Aug 28, 2024 at 02:33:59PM +0900, Akihiko Odaki wrote: > On 2024/08/28 1:11, Peter Xu wrote: > > On Tue, Aug 27, 2024 at 01:14:51PM +0900, Akihiko Odaki wrote: > > > On 2024/08/27 4:42, Peter Xu wrote: > > > > On Mon, Aug 26, 2024 at 06:10:25PM +0100, Peter Maydell wrote: > > > > > On Mon,

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-27 Thread Akihiko Odaki
On 2024/08/28 1:11, Peter Xu wrote: On Tue, Aug 27, 2024 at 01:14:51PM +0900, Akihiko Odaki wrote: On 2024/08/27 4:42, Peter Xu wrote: On Mon, Aug 26, 2024 at 06:10:25PM +0100, Peter Maydell wrote: On Mon, 26 Aug 2024 at 16:22, Peter Xu wrote: On Fri, Aug 23, 2024 at 03:13:11PM +0900, Akihi

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-27 Thread Peter Xu
On Tue, Aug 27, 2024 at 01:14:51PM +0900, Akihiko Odaki wrote: > On 2024/08/27 4:42, Peter Xu wrote: > > On Mon, Aug 26, 2024 at 06:10:25PM +0100, Peter Maydell wrote: > > > On Mon, 26 Aug 2024 at 16:22, Peter Xu wrote: > > > > > > > > On Fri, Aug 23, 2024 at 03:13:11PM +0900, Akihiko Odaki wrote

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-26 Thread Akihiko Odaki
On 2024/08/27 4:42, Peter Xu wrote: On Mon, Aug 26, 2024 at 06:10:25PM +0100, Peter Maydell wrote: On Mon, 26 Aug 2024 at 16:22, Peter Xu wrote: On Fri, Aug 23, 2024 at 03:13:11PM +0900, Akihiko Odaki wrote: memory_region_update_container_subregions() used to call memory_region_ref(), which

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-26 Thread Peter Xu
On Mon, Aug 26, 2024 at 06:10:25PM +0100, Peter Maydell wrote: > On Mon, 26 Aug 2024 at 16:22, Peter Xu wrote: > > > > On Fri, Aug 23, 2024 at 03:13:11PM +0900, Akihiko Odaki wrote: > > > memory_region_update_container_subregions() used to call > > > memory_region_ref(), which creates a reference

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-26 Thread Peter Maydell
On Mon, 26 Aug 2024 at 16:22, Peter Xu wrote: > > On Fri, Aug 23, 2024 at 03:13:11PM +0900, Akihiko Odaki wrote: > > memory_region_update_container_subregions() used to call > > memory_region_ref(), which creates a reference to the owner of the > > subregion, on behalf of the owner of the containe

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-26 Thread Peter Xu
On Fri, Aug 23, 2024 at 03:13:11PM +0900, Akihiko Odaki wrote: > memory_region_update_container_subregions() used to call > memory_region_ref(), which creates a reference to the owner of the > subregion, on behalf of the owner of the container. This results in a > circular reference if the subregio

[PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-22 Thread Akihiko Odaki
memory_region_update_container_subregions() used to call memory_region_ref(), which creates a reference to the owner of the subregion, on behalf of the owner of the container. This results in a circular reference if the subregion and container have the same owner. memory_region_ref() creates a ref