Re: [PATCH v4 5/6] migration: Support periodic RAMBlock dirty bitmap sync

2024-10-17 Thread Yong Huang
On Fri, Oct 18, 2024 at 3:33 AM Peter Xu wrote: > On Thu, Oct 17, 2024 at 02:42:54PM +0800, yong.hu...@smartx.com wrote: > > +void cpu_throttle_dirty_sync_timer_tick(void *opaque) > > +{ > > +static uint64_t prev_sync_cnt; > > We may need to reset this in case migration got cancelled and invo

Re: [PATCH v4 5/6] migration: Support periodic RAMBlock dirty bitmap sync

2024-10-17 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Oct 17, 2024 at 02:42:54PM +0800, yong.hu...@smartx.com wrote: >> +void cpu_throttle_dirty_sync_timer_tick(void *opaque) >> +{ >> +static uint64_t prev_sync_cnt; > > We may need to reset this in case migration got cancelled and invoked > again, to make sure it keeps

Re: [PATCH v4 5/6] migration: Support periodic RAMBlock dirty bitmap sync

2024-10-17 Thread Peter Xu
On Thu, Oct 17, 2024 at 02:42:54PM +0800, yong.hu...@smartx.com wrote: > +void cpu_throttle_dirty_sync_timer_tick(void *opaque) > +{ > +static uint64_t prev_sync_cnt; We may need to reset this in case migration got cancelled and invoked again, to make sure it keeps working in the 2nd run. > +

Re: [PATCH v4 5/6] migration: Support periodic RAMBlock dirty bitmap sync

2024-10-17 Thread Fabiano Rosas
yong.hu...@smartx.com writes: > From: Hyman Huang > > When VM is configured with huge memory, the current throttle logic > doesn't look like to scale, because migration_trigger_throttle() > is only called for each iteration, so it won't be invoked for a long > time if one iteration can take a lon

[PATCH v4 5/6] migration: Support periodic RAMBlock dirty bitmap sync

2024-10-16 Thread yong . huang
From: Hyman Huang When VM is configured with huge memory, the current throttle logic doesn't look like to scale, because migration_trigger_throttle() is only called for each iteration, so it won't be invoked for a long time if one iteration can take a long time. The periodic dirty sync aims to f