Re: [PATCH v4 4/8] hw/arm/virt-acpi-build: Fix comment in build_iort

2025-06-19 Thread Eric Auger
Hi Gustavo, On 6/19/25 7:07 PM, Gustavo Romero wrote: > Hi Eric, > > On 6/17/25 10:22, Eric Auger wrote: >> Hi Gustavo, >> >> On 6/16/25 3:18 PM, Gustavo Romero wrote: >>> The comment about the mapping from SMMU to ITS is incorrect and it >>> reads >>> "RC -> ITS". The code in question actually ma

Re: [PATCH v4 4/8] hw/arm/virt-acpi-build: Fix comment in build_iort

2025-06-19 Thread Gustavo Romero
Hi Eric, On 6/17/25 10:22, Eric Auger wrote: Hi Gustavo, On 6/16/25 3:18 PM, Gustavo Romero wrote: The comment about the mapping from SMMU to ITS is incorrect and it reads "RC -> ITS". The code in question actually maps SMMU -> ITS, so the mapping in question is not direct. The direct mapping,

Re: [PATCH v4 4/8] hw/arm/virt-acpi-build: Fix comment in build_iort

2025-06-17 Thread Eric Auger
Hi Gustavo, On 6/16/25 3:18 PM, Gustavo Romero wrote: > The comment about the mapping from SMMU to ITS is incorrect and it reads > "RC -> ITS". The code in question actually maps SMMU -> ITS, so the > mapping in question is not direct. The direct mapping, i.e., RC -> ITS, > is handled a bit furthe

[PATCH v4 4/8] hw/arm/virt-acpi-build: Fix comment in build_iort

2025-06-16 Thread Gustavo Romero
The comment about the mapping from SMMU to ITS is incorrect and it reads "RC -> ITS". The code in question actually maps SMMU -> ITS, so the mapping in question is not direct. The direct mapping, i.e., RC -> ITS, is handled a bit further down in the code, in the else block, and we take the opportun