Re: [PATCH v4 3/6] hw/adc: Add an ADC module for NPCM7XX

2021-01-07 Thread Hao Wu via
Thanks for your review. We'll apply your suggestions. On Thu, Jan 7, 2021 at 1:07 PM Peter Maydell wrote: > On Thu, 17 Dec 2020 at 00:45, Hao Wu wrote: > > > > The ADC is part of NPCM7XX Module. Its behavior is controled by the > > ADC_CON register. It converts one of the eight analog inputs in

Re: [PATCH v4 3/6] hw/adc: Add an ADC module for NPCM7XX

2021-01-07 Thread Peter Maydell
On Thu, 17 Dec 2020 at 00:45, Hao Wu wrote: > > The ADC is part of NPCM7XX Module. Its behavior is controled by the > ADC_CON register. It converts one of the eight analog inputs into a > digital input and stores it in the ADC_DATA register when enabled. > > Users can alter input value by using qo

[PATCH v4 3/6] hw/adc: Add an ADC module for NPCM7XX

2020-12-16 Thread Hao Wu via
The ADC is part of NPCM7XX Module. Its behavior is controled by the ADC_CON register. It converts one of the eight analog inputs into a digital input and stores it in the ADC_DATA register when enabled. Users can alter input value by using qom-set QMP command. Reviewed-by: Havard Skinnemoen Revi