Re: [PATCH v4 3/4] qga/vss-win32: fix warning for clang++-15

2023-03-22 Thread Daniel P . Berrangé
On Wed, Mar 22, 2023 at 07:18:11PM +0200, Konstantin Kostiuk wrote: > Hi Pierrick, > > Thanks for reminding me. You are fully right to ping me. I really lost this > commit. > As QEMU is already at the code freeze stage, I don't want to push this into > 8.0. FWIW, this kind of fix is perfectly ok

Re: [PATCH v4 3/4] qga/vss-win32: fix warning for clang++-15

2023-03-22 Thread Konstantin Kostiuk
Hi Pierrick, Thanks for reminding me. You are fully right to ping me. I really lost this commit. As QEMU is already at the code freeze stage, I don't want to push this into 8.0. I hope it will be ok to merge after 8.0 was released. Best Regards, Konstantin Kostiuk. On Tue, Mar 21, 2023 at 11:48

Re: [PATCH v4 3/4] qga/vss-win32: fix warning for clang++-15

2023-03-21 Thread Pierrick Bouvier
Sorry to come back on this, but it seems this specific commit was not integrated in trunk. @Konstantin Kostiuk: If you plan to integrate this later (before 8.0 tag), sorry for the noise. Since rc1 was published today, I think it may have been "lost". If someone wants to merge it, that would

[PATCH v4 3/4] qga/vss-win32: fix warning for clang++-15

2023-02-21 Thread Pierrick Bouvier
Reported when compiling with clang-windows-arm64. ../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) { ^