Re: [PATCH v4 3/3] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-10-01 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Oct 01, 2020 at 04:41:52PM +0200, Philippe Mathieu-Daudé wrote: >> Only qemu-system-FOO and qemu-storage-daemon provide QMP >> monitors, therefore such declarations and definitions are >> irrelevant for user-mode emulation. >> >> Restricting the x86-specific com

Re: [PATCH v4 3/3] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-10-01 Thread Eduardo Habkost
On Thu, Oct 01, 2020 at 05:37:26PM +0200, Philippe Mathieu-Daudé wrote: > On 10/1/20 5:29 PM, Eduardo Habkost wrote: > > On Thu, Oct 01, 2020 at 04:41:52PM +0200, Philippe Mathieu-Daudé wrote: > >> Only qemu-system-FOO and qemu-storage-daemon provide QMP > >> monitors, therefore such declarations a

Re: [PATCH v4 3/3] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-10-01 Thread Philippe Mathieu-Daudé
On 10/1/20 5:29 PM, Eduardo Habkost wrote: > On Thu, Oct 01, 2020 at 04:41:52PM +0200, Philippe Mathieu-Daudé wrote: >> Only qemu-system-FOO and qemu-storage-daemon provide QMP >> monitors, therefore such declarations and definitions are >> irrelevant for user-mode emulation. >> >> Restricting the

Re: [PATCH v4 3/3] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-10-01 Thread Eduardo Habkost
On Thu, Oct 01, 2020 at 04:41:52PM +0200, Philippe Mathieu-Daudé wrote: > Only qemu-system-FOO and qemu-storage-daemon provide QMP > monitors, therefore such declarations and definitions are > irrelevant for user-mode emulation. > > Restricting the x86-specific commands to machine-target.json > pu

[PATCH v4 3/3] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-10-01 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the x86-specific commands to machine-target.json pulls less QAPI-generated code into user-mode. Acked-by: Richard Henderson Signed-of