Re: [PATCH v4 21/31] virtio-9p: Fix error_append_hint/error_prepend usage

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 15:58, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 12:19, Greg Kurz wrote: >> On Tue,  1 Oct 2019 18:53:09 +0300 >> Vladimir Sementsov-Ogievskiy wrote: >> >>> If we want to add some info to errp (by error_prepend() or >>> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE ma

Re: [PATCH v4 21/31] virtio-9p: Fix error_append_hint/error_prepend usage

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 12:19, Greg Kurz wrote: > On Tue, 1 Oct 2019 18:53:09 +0300 > Vladimir Sementsov-Ogievskiy wrote: > >> If we want to add some info to errp (by error_prepend() or >> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. >> Otherwise, this info will not be added when errp ==

Re: [PATCH v4 21/31] virtio-9p: Fix error_append_hint/error_prepend usage

2019-10-02 Thread Greg Kurz
On Tue, 1 Oct 2019 18:53:09 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &fatal_err > (the program will exit prior to

[PATCH v4 21/31] virtio-9p: Fix error_append_hint/error_prepend usage

2019-10-01 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &fatal_err (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. This commit