Re: [PATCH v4 2/6] introduce UFFD-WP low-level interface helpers

2020-12-01 Thread Andrey Gruzdev
On 01.12.2020 15:24, Dr. David Alan Gilbert wrote: * Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: Implemented support for the whole RAM block memory protection/un-protection. Introduced higher level ram_write_tracking_start() and ram_write_tracking_stop() to start/stop tracking guest mem

Re: [PATCH v4 2/6] introduce UFFD-WP low-level interface helpers

2020-12-01 Thread Dr. David Alan Gilbert
* Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: > Implemented support for the whole RAM block memory > protection/un-protection. Introduced higher level > ram_write_tracking_start() and ram_write_tracking_stop() > to start/stop tracking guest memory writes. > > Signed-off-by: Andrey Gruzdev

Re: [PATCH v4 2/6] introduce UFFD-WP low-level interface helpers

2020-11-30 Thread Andrey Gruzdev
On 30.11.2020 18:34, Peter Xu wrote: On Sun, Nov 29, 2020 at 11:12:10PM +0300, Andrey Gruzdev wrote: +void ram_write_tracking_stop(void) +{ +#ifdef CONFIG_LINUX +RAMState *rs = ram_state; +RAMBlock *bs; +assert(rs->uffdio_fd >= 0); Maybe too harsh - we can return if it's invalid.

Re: [PATCH v4 2/6] introduce UFFD-WP low-level interface helpers

2020-11-30 Thread Peter Xu
On Sun, Nov 29, 2020 at 11:12:10PM +0300, Andrey Gruzdev wrote: > > > +void ram_write_tracking_stop(void) > > > +{ > > > +#ifdef CONFIG_LINUX > > > +RAMState *rs = ram_state; > > > +RAMBlock *bs; > > > +assert(rs->uffdio_fd >= 0); > > > > Maybe too harsh - we can return if it's invalid

Re: [PATCH v4 2/6] introduce UFFD-WP low-level interface helpers

2020-11-29 Thread Andrey Gruzdev
On 28.11.2020 00:04, Peter Xu wrote: On Thu, Nov 26, 2020 at 06:17:30PM +0300, Andrey Gruzdev wrote: Implemented support for the whole RAM block memory protection/un-protection. Introduced higher level ram_write_tracking_start() and ram_write_tracking_stop() to start/stop tracking guest memory w

Re: [PATCH v4 2/6] introduce UFFD-WP low-level interface helpers

2020-11-27 Thread Peter Xu
On Thu, Nov 26, 2020 at 06:17:30PM +0300, Andrey Gruzdev wrote: > Implemented support for the whole RAM block memory > protection/un-protection. Introduced higher level > ram_write_tracking_start() and ram_write_tracking_stop() > to start/stop tracking guest memory writes. The whole patch looks go

[PATCH v4 2/6] introduce UFFD-WP low-level interface helpers

2020-11-26 Thread Andrey Gruzdev via
Implemented support for the whole RAM block memory protection/un-protection. Introduced higher level ram_write_tracking_start() and ram_write_tracking_stop() to start/stop tracking guest memory writes. Signed-off-by: Andrey Gruzdev --- include/exec/memory.h | 7 ++ include/qemu/userfaultf