Re: [PATCH v4 2/3] block: consolidate blocksize properties consistency checks

2020-05-20 Thread Roman Kagan
On Wed, May 20, 2020 at 10:57:00AM +0200, Philippe Mathieu-Daudé wrote: > On 5/20/20 10:06 AM, Roman Kagan wrote: > > Several block device properties related to blocksize configuration must > > be in certain relationship WRT each other: physical block must be no > > smaller than logical block; min_

Re: [PATCH v4 2/3] block: consolidate blocksize properties consistency checks

2020-05-20 Thread Kevin Wolf
Am 20.05.2020 um 10:59 hat Philippe Mathieu-Daudé geschrieben: > On Wed, May 20, 2020 at 10:57 AM Philippe Mathieu-Daudé > wrote: > > > > Hi Roman, > > > > On 5/20/20 10:06 AM, Roman Kagan wrote: > > > Several block device properties related to blocksize configuration must > > > be in certain re

Re: [PATCH v4 2/3] block: consolidate blocksize properties consistency checks

2020-05-20 Thread Kevin Wolf
Am 20.05.2020 um 10:57 hat Philippe Mathieu-Daudé geschrieben: > Hi Roman, > > On 5/20/20 10:06 AM, Roman Kagan wrote: > > Several block device properties related to blocksize configuration must > > be in certain relationship WRT each other: physical block must be no > > smaller than logical bloc

Re: [PATCH v4 2/3] block: consolidate blocksize properties consistency checks

2020-05-20 Thread Philippe Mathieu-Daudé
On Wed, May 20, 2020 at 10:57 AM Philippe Mathieu-Daudé wrote: > > Hi Roman, > > On 5/20/20 10:06 AM, Roman Kagan wrote: > > Several block device properties related to blocksize configuration must > > be in certain relationship WRT each other: physical block must be no > > smaller than logical blo

Re: [PATCH v4 2/3] block: consolidate blocksize properties consistency checks

2020-05-20 Thread Philippe Mathieu-Daudé
Hi Roman, On 5/20/20 10:06 AM, Roman Kagan wrote: Several block device properties related to blocksize configuration must be in certain relationship WRT each other: physical block must be no smaller than logical block; min_io_size, opt_io_size, and discard_granularity must be a multiple of a log

[PATCH v4 2/3] block: consolidate blocksize properties consistency checks

2020-05-20 Thread Roman Kagan
Several block device properties related to blocksize configuration must be in certain relationship WRT each other: physical block must be no smaller than logical block; min_io_size, opt_io_size, and discard_granularity must be a multiple of a logical block. To ensure these requirements are met, ad