Re: [PATCH v4 16/24] nbd/server: Support 64-bit block status

2023-08-07 Thread Vladimir Sementsov-Ogievskiy
On 04.08.23 22:36, Eric Blake wrote: On Tue, Jun 27, 2023 at 04:23:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 08.06.23 16:56, Eric Blake wrote: The NBD spec states that if the client negotiates extended headers, the server must avoid NBD_REPLY_TYPE_BLOCK_STATUS and instead use NBD_REPLY

Re: [PATCH v4 16/24] nbd/server: Support 64-bit block status

2023-08-04 Thread Eric Blake
On Tue, Jun 27, 2023 at 04:23:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 08.06.23 16:56, Eric Blake wrote: > > The NBD spec states that if the client negotiates extended headers, > > the server must avoid NBD_REPLY_TYPE_BLOCK_STATUS and instead use > > NBD_REPLY_TYPE_BLOCK_STATUS_EXT whic

Re: [PATCH v4 16/24] nbd/server: Support 64-bit block status

2023-06-27 Thread Vladimir Sementsov-Ogievskiy
On 08.06.23 16:56, Eric Blake wrote: The NBD spec states that if the client negotiates extended headers, the server must avoid NBD_REPLY_TYPE_BLOCK_STATUS and instead use NBD_REPLY_TYPE_BLOCK_STATUS_EXT which supports 64-bit lengths, even if the reply does not need more than 32 bits. As of this

[PATCH v4 16/24] nbd/server: Support 64-bit block status

2023-06-08 Thread Eric Blake
The NBD spec states that if the client negotiates extended headers, the server must avoid NBD_REPLY_TYPE_BLOCK_STATUS and instead use NBD_REPLY_TYPE_BLOCK_STATUS_EXT which supports 64-bit lengths, even if the reply does not need more than 32 bits. As of this patch, client->mode is still never NBD_