Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-15 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: [...] > So, if no objections, I plan to resend with old "optional id & qom_path" > designation for devices. We still can do a deprecation in future. Yes, please.

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-15 Thread Vladimir Sementsov-Ogievskiy
On 14.02.23 19:28, Markus Armbruster wrote: Daniel P. Berrangé writes: On Tue, Feb 14, 2023 at 12:57:28PM +0100, Markus Armbruster wrote: Daniel P. Berrangé writes: On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Feb 13, 2023 at 05:

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 14, 2023 at 12:57:28PM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vla

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 14/2/23 13:17, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 14/2/23 12:49, Markus Armbruster wrote: Daniel P. Berrangé writes: >> >> [...] >> > What's the documented way to construct a QOM path, given only an ID as > i

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Philippe Mathieu-Daudé
On 14/2/23 12:49, Markus Armbruster wrote: Daniel P. Berrangé writes: On Tue, Feb 14, 2023 at 10:25:22AM +0100, Peter Krempa wrote: On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogie

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy >> > wrote: >> >> The device field is redundant, because QOM path always include device >

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 14/2/23 12:49, Markus Armbruster wrote: >> Daniel P. Berrangé writes: [...] >>> What's the documented way to construct a QOM path, given only an ID as >>> input ? >> >> QOM paths a gap in our documentation, even though the composition tree >> structure has

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 14, 2023 at 10:25:22AM +0100, Peter Krempa wrote: >> On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote: >> > Daniel P. Berrangé writes: >> > >> > > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy >> > > wrote: >> > >

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Daniel P . Berrangé
On Tue, Feb 14, 2023 at 10:25:22AM +0100, Peter Krempa wrote: > On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > > > > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy > > > wrote: > > >> The device field is redundant, beca

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Markus Armbruster
Markus Armbruster writes: > Daniel P. Berrangé writes: > >> On Tue, Feb 14, 2023 at 10:25:22AM +0100, Peter Krempa wrote: >>> On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote: >>> > Daniel P. Berrangé writes: >>> > >>> > > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Semen

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Peter Krempa
On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > >> The device field is redundant, because QOM path always include device > >> ID when this ID exist. > > > > The

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Daniel P . Berrangé
On Tue, Feb 14, 2023 at 12:57:28PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy > >> > wro

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Daniel P . Berrangé
On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > >> The device field is redundant, because QOM path always include device > >> ID when this ID exist. > > > > T

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> The device field is redundant, because QOM path always include device >> ID when this ID exist. > > The flipside to that view is that applications configuring QEMU are > specifying the de

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Philippe Mathieu-Daudé
On 14/2/23 13:17, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 14/2/23 12:49, Markus Armbruster wrote: Daniel P. Berrangé writes: [...] What's the documented way to construct a QOM path, given only an ID as input ? QOM paths a gap in our documentation, even though the co

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-14 Thread Vladimir Sementsov-Ogievskiy
On 14.02.23 14:57, Markus Armbruster wrote: Daniel P. Berrangé writes: On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: The device field is redundant, because QOM pat

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-13 Thread Daniel P . Berrangé
On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > The device field is redundant, because QOM path always include device > ID when this ID exist. The flipside to that view is that applications configuring QEMU are specifying the device ID for -device (CLI) / device_add

[PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-13 Thread Vladimir Sementsov-Ogievskiy
The device field is redundant, because QOM path always include device ID when this ID exist. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/about/deprecated.rst | 9 + qapi/qdev.json| 12 ++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/docs