Re: [PATCH v4 10/31] i386/sev: Add snp_kvm_init() override for SNP class

2024-05-31 Thread Paolo Bonzini
On Thu, May 30, 2024 at 1:17 PM Pankaj Gupta wrote: > +} else if (x86ms->smm == ON_OFF_AUTO_ON) { > +error_setg(errp, "SEV-SNP does not support SMM."); > +ram_block_discard_disable(false); Unnecessary line, there is no matching ram_block_discard_disable(true). Paolo

[PATCH v4 10/31] i386/sev: Add snp_kvm_init() override for SNP class

2024-05-30 Thread Pankaj Gupta
SNP does not support SMM and requires guest_memfd for private guest memory, so add SNP specific kvm_init() functionality in snp_kvm_init() class method. Signed-off-by: Michael Roth Co-developed-by: Pankaj Gupta Signed-off-by: Pankaj Gupta --- target/i386/sev.c | 23 ++- 1 f