Re: [PATCH v4 10/16] cputlb: Partially inline memory_region_section_get_iotlb

2019-09-25 Thread David Hildenbrand
On 25.09.19 19:55, Richard Henderson wrote: > On 9/24/19 12:59 AM, David Hildenbrand wrote: >>> +is_ram = memory_region_is_ram(section->mr); >>> +is_romd = memory_region_is_romd(section->mr); >>> + >>> +if (is_ram || is_romd) { >>> +/* RAM and ROMD both have associated host memo

Re: [PATCH v4 10/16] cputlb: Partially inline memory_region_section_get_iotlb

2019-09-25 Thread Richard Henderson
On 9/24/19 12:59 AM, David Hildenbrand wrote: >> +is_ram = memory_region_is_ram(section->mr); >> +is_romd = memory_region_is_romd(section->mr); >> + >> +if (is_ram || is_romd) { >> +/* RAM and ROMD both have associated host memory. */ >> addend = (uintptr_t)memory_regio

Re: [PATCH v4 10/16] cputlb: Partially inline memory_region_section_get_iotlb

2019-09-25 Thread Alex Bennée
Richard Henderson writes: > There is only one caller, tlb_set_page_with_attrs. We cannot > inline the entire function because the AddressSpaceDispatch > structure is private to exec.c, and cannot easily be moved to > include/exec/memory-internal.h. > > Compute is_ram and is_romd once within tl

Re: [PATCH v4 10/16] cputlb: Partially inline memory_region_section_get_iotlb

2019-09-24 Thread David Hildenbrand
On 24.09.19 00:59, Richard Henderson wrote: > There is only one caller, tlb_set_page_with_attrs. We cannot > inline the entire function because the AddressSpaceDispatch > structure is private to exec.c, and cannot easily be moved to > include/exec/memory-internal.h. > > Compute is_ram and is_romd

[PATCH v4 10/16] cputlb: Partially inline memory_region_section_get_iotlb

2019-09-23 Thread Richard Henderson
There is only one caller, tlb_set_page_with_attrs. We cannot inline the entire function because the AddressSpaceDispatch structure is private to exec.c, and cannot easily be moved to include/exec/memory-internal.h. Compute is_ram and is_romd once within tlb_set_page_with_attrs. Fold the number of