Re: [PATCH v4 10/15] hw/nvme: Remove reg_size variable and update BAR0 size calculation

2022-02-11 Thread Klaus Jensen
On Jan 26 18:11, Lukasz Maniak wrote: > From: Łukasz Gieryk > > The n->reg_size parameter unnecessarily splits the BAR0 size calculation > in two phases; removed to simplify the code. > > With all the calculations done in one place, it seems the pow2ceil, > applied originally to reg_size, is unn

[PATCH v4 10/15] hw/nvme: Remove reg_size variable and update BAR0 size calculation

2022-01-26 Thread Lukasz Maniak
From: Łukasz Gieryk The n->reg_size parameter unnecessarily splits the BAR0 size calculation in two phases; removed to simplify the code. With all the calculations done in one place, it seems the pow2ceil, applied originally to reg_size, is unnecessary. The rounding should happen as the last ste