Re: [PATCH v4 1/7] keyval: Fix and clarify grammar

2020-10-19 Thread Markus Armbruster
Eric Blake writes: > On 10/11/20 2:34 AM, Markus Armbruster wrote: >> The grammar has a few issues: >> * key-fragment = / [^=,.]* / >>Prose restricts key fragments: they "must be valid QAPI names or >>consist only of decimal digits". Technically, '' consists only of >>decimal digits.

Re: [PATCH v4 1/7] keyval: Fix and clarify grammar

2020-10-12 Thread Eric Blake
On 10/11/20 2:34 AM, Markus Armbruster wrote: The grammar has a few issues: * key-fragment = / [^=,.]* / Prose restricts key fragments: they "must be valid QAPI names or consist only of decimal digits". Technically, '' consists only of decimal digits. The code rejects that. Fix the

[PATCH v4 1/7] keyval: Fix and clarify grammar

2020-10-11 Thread Markus Armbruster
The grammar has a few issues: * key-fragment = / [^=,.]* / Prose restricts key fragments: they "must be valid QAPI names or consist only of decimal digits". Technically, '' consists only of decimal digits. The code rejects that. Fix the grammar. * val = { / [^,]* / | ',,' }