Re: [PATCH v4 1/3] virtiofsd: extract lo_do_open() from lo_open()

2021-02-03 Thread Greg Kurz
On Wed, 3 Feb 2021 16:45:10 +0100 Greg Kurz wrote: > On Wed, 3 Feb 2021 14:47:30 + > "Dr. David Alan Gilbert" wrote: > > > * Greg Kurz (gr...@kaod.org) wrote: > > > On Wed, 3 Feb 2021 11:37:17 + > > > Stefan Hajnoczi wrote: > > > > > > > Both lo_open() and lo_create() have similar co

Re: [PATCH v4 1/3] virtiofsd: extract lo_do_open() from lo_open()

2021-02-03 Thread Stefan Hajnoczi
On Wed, Feb 03, 2021 at 02:47:30PM +, Dr. David Alan Gilbert wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > On Wed, 3 Feb 2021 11:37:17 + > > Stefan Hajnoczi wrote: > > > > > Both lo_open() and lo_create() have similar code to open a file. Extract > > > a common lo_do_open() function f

Re: [PATCH v4 1/3] virtiofsd: extract lo_do_open() from lo_open()

2021-02-03 Thread Greg Kurz
On Wed, 3 Feb 2021 14:47:30 + "Dr. David Alan Gilbert" wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > On Wed, 3 Feb 2021 11:37:17 + > > Stefan Hajnoczi wrote: > > > > > Both lo_open() and lo_create() have similar code to open a file. Extract > > > a common lo_do_open() function from

Re: [PATCH v4 1/3] virtiofsd: extract lo_do_open() from lo_open()

2021-02-03 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > On Wed, 3 Feb 2021 11:37:17 + > Stefan Hajnoczi wrote: > > > Both lo_open() and lo_create() have similar code to open a file. Extract > > a common lo_do_open() function from lo_open() that will be used by > > lo_create() in a later commit. > > > > Since

Re: [PATCH v4 1/3] virtiofsd: extract lo_do_open() from lo_open()

2021-02-03 Thread Greg Kurz
On Wed, 3 Feb 2021 11:37:17 + Stefan Hajnoczi wrote: > Both lo_open() and lo_create() have similar code to open a file. Extract > a common lo_do_open() function from lo_open() that will be used by > lo_create() in a later commit. > > Since lo_do_open() does not otherwise need fuse_req_t req

[PATCH v4 1/3] virtiofsd: extract lo_do_open() from lo_open()

2021-02-03 Thread Stefan Hajnoczi
Both lo_open() and lo_create() have similar code to open a file. Extract a common lo_do_open() function from lo_open() that will be used by lo_create() in a later commit. Since lo_do_open() does not otherwise need fuse_req_t req, convert lo_add_fd_mapping() to use struct lo_data *lo instead. Sign