Re: Re: [PATCH v4 1/2] qapi: Avoid generating C identifier 'linux'

2022-07-06 Thread zhenwei pi
On 7/7/22 14:26, Markus Armbruster wrote: zhenwei pi writes: 'linux' is not usable as identifier, because C compilers targeting Linux predefine it as a macro expanding to 1. Add it to @polluted_words. 'unix' is already there. Suggested-by: Markus Armbruster Reviewed-by: Marc-André Lureau

Re: [PATCH v4 1/2] qapi: Avoid generating C identifier 'linux'

2022-07-06 Thread Markus Armbruster
zhenwei pi writes: > 'linux' is not usable as identifier, because C compilers targeting > Linux predefine it as a macro expanding to 1. Add it to > @polluted_words. 'unix' is already there. > > Suggested-by: Markus Armbruster > Reviewed-by: Marc-André Lureau > Signed-off-by: zhenwei pi > ---

[PATCH v4 1/2] qapi: Avoid generating C identifier 'linux'

2022-07-06 Thread zhenwei pi
'linux' is not usable as identifier, because C compilers targeting Linux predefine it as a macro expanding to 1. Add it to @polluted_words. 'unix' is already there. Suggested-by: Markus Armbruster Reviewed-by: Marc-André Lureau Signed-off-by: zhenwei pi --- scripts/qapi/common.py | 2 +- 1 fi