Re: [PATCH v4 09/13] mirror: Drop redundant zero_target parameter

2025-05-14 Thread Eric Blake
On Wed, May 14, 2025 at 05:09:14PM -0500, Eric Blake wrote: > On Fri, May 09, 2025 at 03:40:26PM -0500, Eric Blake wrote: > > The two callers to a mirror job (drive-mirror and blockdev-mirror) set > > zero_target precisely when sync mode == FULL, with the one exception > > that drive-mirror skips z

Re: [PATCH v4 09/13] mirror: Drop redundant zero_target parameter

2025-05-14 Thread Eric Blake
On Fri, May 09, 2025 at 03:40:26PM -0500, Eric Blake wrote: > The two callers to a mirror job (drive-mirror and blockdev-mirror) set > zero_target precisely when sync mode == FULL, with the one exception > that drive-mirror skips zeroing the target if it was newly created and > reads as zero. But

Re: [PATCH v4 09/13] mirror: Drop redundant zero_target parameter

2025-05-13 Thread Sunny Zhu
On Fri, May 09, 2025 at 03:40:26PM -0500, Eric Blake wrote: > The two callers to a mirror job (drive-mirror and blockdev-mirror) set > zero_target precisely when sync mode == FULL, with the one exception > that drive-mirror skips zeroing the target if it was newly created and > reads as zero. But

Re: [PATCH v4 09/13] mirror: Drop redundant zero_target parameter

2025-05-12 Thread Stefan Hajnoczi
On Fri, May 09, 2025 at 03:40:26PM -0500, Eric Blake wrote: > The two callers to a mirror job (drive-mirror and blockdev-mirror) set > zero_target precisely when sync mode == FULL, with the one exception > that drive-mirror skips zeroing the target if it was newly created and > reads as zero. But

[PATCH v4 09/13] mirror: Drop redundant zero_target parameter

2025-05-09 Thread Eric Blake
The two callers to a mirror job (drive-mirror and blockdev-mirror) set zero_target precisely when sync mode == FULL, with the one exception that drive-mirror skips zeroing the target if it was newly created and reads as zero. But given the previous patch, that exception is equally captured by targ