Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Will Cohen
On Mon, Feb 7, 2022 at 5:48 PM Christian Schoenebeck wrote: > On Montag, 7. Februar 2022 22:07:34 CET Will Cohen wrote: > > On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck > > > > wrote: > > > On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: > > > > * Greg Kurz (gr...@k

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Christian Schoenebeck
On Montag, 7. Februar 2022 22:07:34 CET Will Cohen wrote: > On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck > > wrote: > > On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: > > > * Greg Kurz (gr...@kaod.org) wrote: > > > > On Mon, 7 Feb 2022 11:30:18 +0100 > > > > > > > >

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Will Cohen
On Mon, Feb 7, 2022 at 4:07 PM Will Cohen wrote: > On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck < > qemu_...@crudebyte.com> wrote: > >> On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: >> > * Greg Kurz (gr...@kaod.org) wrote: >> > > On Mon, 7 Feb 2022 11:30:18 +0100 >

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Will Cohen
On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck wrote: > On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: > > * Greg Kurz (gr...@kaod.org) wrote: > > > On Mon, 7 Feb 2022 11:30:18 +0100 > > > > > > Philippe Mathieu-Daudé wrote: > > > > On 7/2/22 09:47, Greg Kurz wrote:

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Vivek Goyal
On Mon, Feb 07, 2022 at 11:49:12AM +0100, Greg Kurz wrote: > On Mon, 7 Feb 2022 11:30:18 +0100 > Philippe Mathieu-Daudé wrote: > > > On 7/2/22 09:47, Greg Kurz wrote: > > > On Sun, 6 Feb 2022 20:10:23 -0500 > > > Will Cohen wrote: > > > > > >> This patch set currently places it in 9p-util only

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Christian Schoenebeck
On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > On Mon, 7 Feb 2022 11:30:18 +0100 > > > > Philippe Mathieu-Daudé wrote: > > > On 7/2/22 09:47, Greg Kurz wrote: > > > > On Sun, 6 Feb 2022 20:10:23 -0500 > > > > > > > > Will Cohen wr

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > On Mon, 7 Feb 2022 11:30:18 +0100 > Philippe Mathieu-Daudé wrote: > > > On 7/2/22 09:47, Greg Kurz wrote: > > > On Sun, 6 Feb 2022 20:10:23 -0500 > > > Will Cohen wrote: > > > > > >> This patch set currently places it in 9p-util only because 9p is the only

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Greg Kurz
On Mon, 7 Feb 2022 11:30:18 +0100 Philippe Mathieu-Daudé wrote: > On 7/2/22 09:47, Greg Kurz wrote: > > On Sun, 6 Feb 2022 20:10:23 -0500 > > Will Cohen wrote: > > > >> This patch set currently places it in 9p-util only because 9p is the only > >> place where this issue seems to have come up so

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Philippe Mathieu-Daudé via
On 7/2/22 09:47, Greg Kurz wrote: On Sun, 6 Feb 2022 20:10:23 -0500 Will Cohen wrote: This patch set currently places it in 9p-util only because 9p is the only place where this issue seems to have come up so far and we were wary of editing files too far afield, but I have no attachment to its

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-07 Thread Greg Kurz
On Sun, 6 Feb 2022 20:10:23 -0500 Will Cohen wrote: > This patch set currently places it in 9p-util only because 9p is the only > place where this issue seems to have come up so far and we were wary of > editing files too far afield, but I have no attachment to its specific > location! > Inline

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-06 Thread Will Cohen
This patch set currently places it in 9p-util only because 9p is the only place where this issue seems to have come up so far and we were wary of editing files too far afield, but I have no attachment to its specific location! On Sun, Feb 6, 2022 at 4:21 PM Philippe Mathieu-Daudé wrote: > On 6/2

Re: [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-06 Thread Philippe Mathieu-Daudé via
On 6/2/22 21:07, Will Cohen wrote: From: Keno Fischer Darwin does not support mknodat. However, to avoid race conditions with later setting the permissions, we must avoid using mknod on the full path instead. We could try to fchdir, but that would cause problems if multiple threads try to call

[PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-06 Thread Will Cohen
From: Keno Fischer Darwin does not support mknodat. However, to avoid race conditions with later setting the permissions, we must avoid using mknod on the full path instead. We could try to fchdir, but that would cause problems if multiple threads try to call mknodat at the same time. However, lu