Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-07 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Feb 07, 2025 at 10:17:19AM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Thu, Feb 06, 2025 at 02:32:12PM -0300, Fabiano Rosas wrote: >> >> > In any case we'd still need some kind of a compatibility behavior for >> >> > the TLS bit stream emitted by older

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-07 Thread Peter Xu
On Fri, Feb 07, 2025 at 10:17:19AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Thu, Feb 06, 2025 at 02:32:12PM -0300, Fabiano Rosas wrote: > >> > In any case we'd still need some kind of a compatibility behavior for > >> > the TLS bit stream emitted by older QEMU versions (which is al

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-07 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Feb 06, 2025 at 02:32:12PM -0300, Fabiano Rosas wrote: >> > In any case we'd still need some kind of a compatibility behavior for >> > the TLS bit stream emitted by older QEMU versions (which is always >> > improperly terminated). >> > >> >> There is no compat issue. F

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-06 Thread Peter Xu
On Thu, Feb 06, 2025 at 02:32:12PM -0300, Fabiano Rosas wrote: > > In any case we'd still need some kind of a compatibility behavior for > > the TLS bit stream emitted by older QEMU versions (which is always > > improperly terminated). > > > > There is no compat issue. For <= 9.2, QEMU is still do

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-06 Thread Maciej S. Szmigiero
On 6.02.2025 18:32, Fabiano Rosas wrote: "Maciej S. Szmigiero" writes: On 6.02.2025 16:20, Fabiano Rosas wrote: "Maciej S. Szmigiero" writes: (..) Even if non-TLS behaved the same, why would we choose to port a bug to the TLS implementation? We could of course decide at this point to pun

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-06 Thread Fabiano Rosas
"Maciej S. Szmigiero" writes: > On 6.02.2025 16:20, Fabiano Rosas wrote: >> "Maciej S. Szmigiero" writes: >> >>> On 6.02.2025 15:13, Fabiano Rosas wrote: "Maciej S. Szmigiero" writes: > On 5.02.2025 21:42, Fabiano Rosas wrote: >> Fabiano Rosas writes: >> >>> Daniel P

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-06 Thread Maciej S. Szmigiero
On 6.02.2025 16:20, Fabiano Rosas wrote: "Maciej S. Szmigiero" writes: On 6.02.2025 15:13, Fabiano Rosas wrote: "Maciej S. Szmigiero" writes: On 5.02.2025 21:42, Fabiano Rosas wrote: Fabiano Rosas writes: Daniel P. Berrangé writes: On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-06 Thread Fabiano Rosas
"Maciej S. Szmigiero" writes: > On 6.02.2025 15:13, Fabiano Rosas wrote: >> "Maciej S. Szmigiero" writes: >> >>> On 5.02.2025 21:42, Fabiano Rosas wrote: Fabiano Rosas writes: > Daniel P. Berrangé writes: > >> On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu wrote: >>>

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-06 Thread Maciej S. Szmigiero
On 6.02.2025 15:13, Fabiano Rosas wrote: "Maciej S. Szmigiero" writes: On 5.02.2025 21:42, Fabiano Rosas wrote: Fabiano Rosas writes: Daniel P. Berrangé writes: On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu wrote: On Tue, Feb 04, 2025 at 03:39:00PM +0100, Maciej S. Szmigiero wrote

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-06 Thread Fabiano Rosas
"Maciej S. Szmigiero" writes: > On 5.02.2025 21:42, Fabiano Rosas wrote: >> Fabiano Rosas writes: >> >>> Daniel P. Berrangé writes: >>> On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu wrote: > On Tue, Feb 04, 2025 at 03:39:00PM +0100, Maciej S. Szmigiero wrote: >> On 3.02.2025

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-06 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Feb 05, 2025 at 05:42:37PM -0300, Fabiano Rosas wrote: >> Fabiano Rosas writes: >> >> > Daniel P. Berrangé writes: >> > >> >> On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu wrote: >> >>> On Tue, Feb 04, 2025 at 03:39:00PM +0100, Maciej S. Szmigiero wrote: >> >>>

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-05 Thread Peter Xu
On Wed, Feb 05, 2025 at 05:42:37PM -0300, Fabiano Rosas wrote: > Fabiano Rosas writes: > > > Daniel P. Berrangé writes: > > > >> On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu wrote: > >>> On Tue, Feb 04, 2025 at 03:39:00PM +0100, Maciej S. Szmigiero wrote: > >>> > On 3.02.2025 23:56, Peter

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-05 Thread Maciej S. Szmigiero
On 5.02.2025 21:42, Fabiano Rosas wrote: Fabiano Rosas writes: Daniel P. Berrangé writes: On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu wrote: On Tue, Feb 04, 2025 at 03:39:00PM +0100, Maciej S. Szmigiero wrote: On 3.02.2025 23:56, Peter Xu wrote: On Mon, Feb 03, 2025 at 10:41:32PM

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-05 Thread Fabiano Rosas
Fabiano Rosas writes: > Daniel P. Berrangé writes: > >> On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu wrote: >>> On Tue, Feb 04, 2025 at 03:39:00PM +0100, Maciej S. Szmigiero wrote: >>> > On 3.02.2025 23:56, Peter Xu wrote: >>> > > On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigie

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-05 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu wrote: >> On Tue, Feb 04, 2025 at 03:39:00PM +0100, Maciej S. Szmigiero wrote: >> > On 3.02.2025 23:56, Peter Xu wrote: >> > > On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigiero wrote: >> > > > On 3.02.2025

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Maciej S. Szmigiero
On 4.02.2025 19:25, Fabiano Rosas wrote: Peter Xu writes: On Tue, Feb 04, 2025 at 03:08:02PM +, Daniel P. Berrangé wrote: On Mon, Feb 03, 2025 at 01:20:01PM -0500, Peter Xu wrote: On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" Multifd

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Feb 04, 2025 at 03:08:02PM +, Daniel P. Berrangé wrote: >> On Mon, Feb 03, 2025 at 01:20:01PM -0500, Peter Xu wrote: >> > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: >> > > From: "Maciej S. Szmigiero" >> > > >> > > Multifd send channels ar

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Peter Xu
On Tue, Feb 04, 2025 at 04:12:15PM +, Daniel P. Berrangé wrote: > On Tue, Feb 04, 2025 at 11:02:28AM -0500, Peter Xu wrote: > > On Tue, Feb 04, 2025 at 03:08:02PM +, Daniel P. Berrangé wrote: > > > On Mon, Feb 03, 2025 at 01:20:01PM -0500, Peter Xu wrote: > > > > On Thu, Jan 30, 2025 at 11:

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Peter Xu
On Tue, Feb 04, 2025 at 03:08:02PM +, Daniel P. Berrangé wrote: > On Mon, Feb 03, 2025 at 01:20:01PM -0500, Peter Xu wrote: > > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: > > > From: "Maciej S. Szmigiero" > > > > > > Multifd send channels are terminated by calling >

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Daniel P . Berrangé
On Tue, Feb 04, 2025 at 11:02:28AM -0500, Peter Xu wrote: > On Tue, Feb 04, 2025 at 03:08:02PM +, Daniel P. Berrangé wrote: > > On Mon, Feb 03, 2025 at 01:20:01PM -0500, Peter Xu wrote: > > > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: > > > > From: "Maciej S. Szmigiero

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Daniel P . Berrangé
On Tue, Feb 04, 2025 at 10:31:31AM -0500, Peter Xu wrote: > On Tue, Feb 04, 2025 at 03:39:00PM +0100, Maciej S. Szmigiero wrote: > > On 3.02.2025 23:56, Peter Xu wrote: > > > On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigiero wrote: > > > > On 3.02.2025 21:20, Peter Xu wrote: > > > > > O

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Daniel P . Berrangé
On Mon, Feb 03, 2025 at 01:20:01PM -0500, Peter Xu wrote: > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: > > From: "Maciej S. Szmigiero" > > > > Multifd send channels are terminated by calling > > qio_channel_shutdown(QIO_CHANNEL_SHUTDOWN_BOTH) in > > multifd_send_terminat

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Peter Xu
On Tue, Feb 04, 2025 at 03:39:00PM +0100, Maciej S. Szmigiero wrote: > On 3.02.2025 23:56, Peter Xu wrote: > > On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigiero wrote: > > > On 3.02.2025 21:20, Peter Xu wrote: > > > > On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote:

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Maciej S. Szmigiero
On 4.02.2025 16:00, Fabiano Rosas wrote: "Maciej S. Szmigiero" writes: On 3.02.2025 23:56, Peter Xu wrote: On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigiero wrote: On 3.02.2025 21:20, Peter Xu wrote: On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: On 3.02.2

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Daniel P . Berrangé
On Mon, Feb 03, 2025 at 03:20:50PM -0500, Peter Xu wrote: > On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: > > On 3.02.2025 19:20, Peter Xu wrote: > > > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: > > > > From: "Maciej S. Szmigiero" > > > > > > > > M

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Fabiano Rosas
"Maciej S. Szmigiero" writes: > On 3.02.2025 23:56, Peter Xu wrote: >> On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigiero wrote: >>> On 3.02.2025 21:20, Peter Xu wrote: On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: > On 3.02.2025 19:20, Peter Xu wrote: >

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Maciej S. Szmigiero
On 3.02.2025 23:56, Peter Xu wrote: On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigiero wrote: On 3.02.2025 21:20, Peter Xu wrote: On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: On 3.02.2025 19:20, Peter Xu wrote: On Thu, Jan 30, 2025 at 11:08:29AM +0100, Macie

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-04 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigiero wrote: >> On 3.02.2025 21:20, Peter Xu wrote: >> > On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: >> > > On 3.02.2025 19:20, Peter Xu wrote: >> > > > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Ma

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Peter Xu
On Mon, Feb 03, 2025 at 10:41:32PM +0100, Maciej S. Szmigiero wrote: > On 3.02.2025 21:20, Peter Xu wrote: > > On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: > > > On 3.02.2025 19:20, Peter Xu wrote: > > > > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote:

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Maciej S. Szmigiero
On 3.02.2025 21:20, Peter Xu wrote: On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: On 3.02.2025 19:20, Peter Xu wrote: On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" Multifd send channels are terminated by calling qio_ch

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Peter Xu
On Mon, Feb 03, 2025 at 07:53:00PM +0100, Maciej S. Szmigiero wrote: > On 3.02.2025 19:20, Peter Xu wrote: > > On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: > > > From: "Maciej S. Szmigiero" > > > > > > Multifd send channels are terminated by calling > > > qio_channel_shutd

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Maciej S. Szmigiero
On 3.02.2025 19:20, Peter Xu wrote: On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" Multifd send channels are terminated by calling qio_channel_shutdown(QIO_CHANNEL_SHUTDOWN_BOTH) in multifd_send_terminate_threads(), which in the TLS case essent

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Peter Xu
On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > Multifd send channels are terminated by calling > qio_channel_shutdown(QIO_CHANNEL_SHUTDOWN_BOTH) in > multifd_send_terminate_threads(), which in the TLS case essentially > calls shutdown(SHUT_R

[PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-01-30 Thread Maciej S. Szmigiero
From: "Maciej S. Szmigiero" Multifd send channels are terminated by calling qio_channel_shutdown(QIO_CHANNEL_SHUTDOWN_BOTH) in multifd_send_terminate_threads(), which in the TLS case essentially calls shutdown(SHUT_RDWR) on the underlying raw socket. Unfortunately, this does not terminate the TL