Re: [PATCH v4 08/19] migration: Add postcopy-preempt capability

2022-04-20 Thread Peter Xu
On Wed, Apr 20, 2022 at 11:51:28AM +0100, Daniel P. Berrangé wrote: > > diff --git a/qapi/migration.json b/qapi/migration.json > > index 18e2610e88..3523f23386 100644 > > --- a/qapi/migration.json > > +++ b/qapi/migration.json > > @@ -463,6 +463,12 @@ > > # procedure starts.

Re: [PATCH v4 08/19] migration: Add postcopy-preempt capability

2022-04-20 Thread Daniel P . Berrangé
On Thu, Mar 31, 2022 at 11:08:46AM -0400, Peter Xu wrote: > Firstly, postcopy already preempts precopy due to the fact that we do > unqueue_page() first before looking into dirty bits. > > However that's not enough, e.g., when there're host huge page enabled, when > sending a precopy huge page, a

[PATCH v4 08/19] migration: Add postcopy-preempt capability

2022-03-31 Thread Peter Xu
Firstly, postcopy already preempts precopy due to the fact that we do unqueue_page() first before looking into dirty bits. However that's not enough, e.g., when there're host huge page enabled, when sending a precopy huge page, a postcopy request needs to wait until the whole huge page that is sen