Re: [PATCH v4 06/16] cputlb: Introduce TLB_BSWAP

2019-09-25 Thread Richard Henderson
On 9/24/19 11:25 AM, Alex Bennée wrote: >> - >> -/* The backing page may or may not require I/O. */ >> -tlb_addr &= ~TLB_WATCHPOINT; >> -if ((tlb_addr & ~TARGET_PAGE_MASK) == 0) { >> -goto do_aligned_access; >> -} >> } >> >

Re: [PATCH v4 06/16] cputlb: Introduce TLB_BSWAP

2019-09-24 Thread Alex Bennée
Richard Henderson writes: > Handle bswap on ram directly in load/store_helper. This fixes a > bug with the previous implementation in that one cannot use the > I/O path for RAM. > > Fixes: a26fc6f5152b47f1 > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson > --- > include/e

[PATCH v4 06/16] cputlb: Introduce TLB_BSWAP

2019-09-23 Thread Richard Henderson
Handle bswap on ram directly in load/store_helper. This fixes a bug with the previous implementation in that one cannot use the I/O path for RAM. Fixes: a26fc6f5152b47f1 Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- include/exec/cpu-all.h | 4 ++- accel/tcg/cputlb.c