Re: [PATCH v4 05/31] scripts: add script to fix error_append_hint/error_prepend usage

2019-10-01 Thread Vladimir Sementsov-Ogievskiy
01.10.2019 19:50, Eric Blake wrote: > On 10/1/19 10:52 AM, Vladimir Sementsov-Ogievskiy wrote: >> error_append_hint and error_prepend will not work, if errp == >> &fatal_error, as program will exit before error_append_hint or >> error_prepend call. Fix this by use of special macro >> ERRP_AUTO_PROP

Re: [PATCH v4 05/31] scripts: add script to fix error_append_hint/error_prepend usage

2019-10-01 Thread Eric Blake
On 10/1/19 11:50 AM, Eric Blake wrote: On 10/1/19 10:52 AM, Vladimir Sementsov-Ogievskiy wrote: error_append_hint and error_prepend will not work, if errp == &fatal_error, as program will exit before error_append_hint or error_prepend call. Fix this by use of special macro ERRP_AUTO_PROPAGATE.

Re: [PATCH v4 05/31] scripts: add script to fix error_append_hint/error_prepend usage

2019-10-01 Thread Vladimir Sementsov-Ogievskiy
01.10.2019 19:22, Eric Blake wrote: > On 10/1/19 10:52 AM, Vladimir Sementsov-Ogievskiy wrote: >> error_append_hint and error_prepend will not work, if errp == >> &fatal_error, as program will exit before error_append_hint or >> error_prepend call. Fix this by use of special macro >> ERRP_AUTO_PROP

Re: [PATCH v4 05/31] scripts: add script to fix error_append_hint/error_prepend usage

2019-10-01 Thread Eric Blake
On 10/1/19 10:52 AM, Vladimir Sementsov-Ogievskiy wrote: error_append_hint and error_prepend will not work, if errp == &fatal_error, as program will exit before error_append_hint or error_prepend call. Fix this by use of special macro ERRP_AUTO_PROPAGATE. Signed-off-by: Vladimir Sementsov-Ogievs

Re: [PATCH v4 05/31] scripts: add script to fix error_append_hint/error_prepend usage

2019-10-01 Thread Eric Blake
On 10/1/19 10:52 AM, Vladimir Sementsov-Ogievskiy wrote: error_append_hint and error_prepend will not work, if errp == &fatal_error, as program will exit before error_append_hint or error_prepend call. Fix this by use of special macro ERRP_AUTO_PROPAGATE. This patch doesn't actually fix any cod

[PATCH v4 05/31] scripts: add script to fix error_append_hint/error_prepend usage

2019-10-01 Thread Vladimir Sementsov-Ogievskiy
error_append_hint and error_prepend will not work, if errp == &fatal_error, as program will exit before error_append_hint or error_prepend call. Fix this by use of special macro ERRP_AUTO_PROPAGATE. Signed-off-by: Vladimir Sementsov-Ogievskiy --- CC: kw...@redhat.com CC: mre...@redhat.com CC: js