Re: [PATCH v4 05/24] q800: move CPU object into Q800MachineState

2023-06-21 Thread Laurent Vivier
Le 21/06/2023 à 16:28, Mark Cave-Ayland a écrit : On 21/06/2023 12:56, BALATON Zoltan wrote: On Wed, 21 Jun 2023, Mark Cave-Ayland wrote: Also change the instantiation of the CPU to use object_initialize_child() followed by a separate realisation. Also seems to restrict valid CPU types but n

Re: [PATCH v4 05/24] q800: move CPU object into Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
On 21/06/2023 12:56, BALATON Zoltan wrote: On Wed, 21 Jun 2023, Mark Cave-Ayland wrote: Also change the instantiation of the CPU to use object_initialize_child() followed by a separate realisation. Also seems to restrict valid CPU types but not mentioned in commit message. Should this patch

Re: [PATCH v4 05/24] q800: move CPU object into Q800MachineState

2023-06-21 Thread BALATON Zoltan
On Wed, 21 Jun 2023, Mark Cave-Ayland wrote: Also change the instantiation of the CPU to use object_initialize_child() followed by a separate realisation. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 18 ++

Re: [PATCH v4 05/24] q800: move CPU object into Q800MachineState

2023-06-21 Thread BALATON Zoltan
On Wed, 21 Jun 2023, Mark Cave-Ayland wrote: Also change the instantiation of the CPU to use object_initialize_child() followed by a separate realisation. Also seems to restrict valid CPU types but not mentioned in commit message. Should this patch be split up? Regards, BALATON Zoltan Sign

[PATCH v4 05/24] q800: move CPU object into Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the CPU to use object_initialize_child() followed by a separate realisation. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 18 +- include/hw/m68k/q800.h | 3 +++ 2 f