Re: [PATCH v4 05/14] tpm_crb: move ACPI table building to device interface

2023-11-03 Thread Stefan Berger
On 11/2/23 22:37, Joelle van Dyne wrote: On Thu, Nov 2, 2023 at 11:50 AM Stefan Berger wrote: On 10/31/23 00:00, Joelle van Dyne wrote: This logic is similar to TPM TIS ISA device. Since TPM CRB can only support TPM 2.0 backends, we check for this in realize. The problem on x86_64 is t

Re: [PATCH v4 05/14] tpm_crb: move ACPI table building to device interface

2023-11-02 Thread Joelle van Dyne
On Thu, Nov 2, 2023 at 11:50 AM Stefan Berger wrote: > > > > On 10/31/23 00:00, Joelle van Dyne wrote: > > This logic is similar to TPM TIS ISA device. Since TPM CRB can only > > support TPM 2.0 backends, we check for this in realize. > > The problem on x86_64 is that the creation of the ACPI does

Re: [PATCH v4 05/14] tpm_crb: move ACPI table building to device interface

2023-11-02 Thread Stefan Berger
On 10/31/23 00:00, Joelle van Dyne wrote: This logic is similar to TPM TIS ISA device. Since TPM CRB can only support TPM 2.0 backends, we check for this in realize. The problem on x86_64 is that the creation of the ACPI doesn't seem to get invoked. The device then ends up not working under

[PATCH v4 05/14] tpm_crb: move ACPI table building to device interface

2023-10-30 Thread Joelle van Dyne
This logic is similar to TPM TIS ISA device. Since TPM CRB can only support TPM 2.0 backends, we check for this in realize. Signed-off-by: Joelle van Dyne Reviewed-by: Stefan Berger --- hw/tpm/tpm_crb.h| 2 ++ hw/i386/acpi-build.c| 23 --- hw/tpm/tpm_crb.c