Re: [PATCH v4 04/14] qapi/introspect.py: guard against ifcond/comment misuse

2021-02-04 Thread Markus Armbruster
John Snow writes: > On 2/3/21 9:08 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> _tree_to_qlit is called recursively on dict values alone; at such a >>> point in generating output it is too late to apply an ifcond. Similarly, >>> comments do not necessarily have a "tidy" place they c

Re: [PATCH v4 04/14] qapi/introspect.py: guard against ifcond/comment misuse

2021-02-03 Thread Eduardo Habkost
On Wed, Feb 03, 2021 at 03:42:54PM -0500, John Snow wrote: > On 2/3/21 9:08 AM, Markus Armbruster wrote: > > John Snow writes: > > > > > _tree_to_qlit is called recursively on dict values alone; at such a > > > point in generating output it is too late to apply an ifcond. Similarly, > > > comment

Re: [PATCH v4 04/14] qapi/introspect.py: guard against ifcond/comment misuse

2021-02-03 Thread John Snow
On 2/3/21 9:08 AM, Markus Armbruster wrote: John Snow writes: _tree_to_qlit is called recursively on dict values alone; at such a point in generating output it is too late to apply an ifcond. Similarly, comments do not necessarily have a "tidy" place they can be printed in such a circumstance.

Re: [PATCH v4 04/14] qapi/introspect.py: guard against ifcond/comment misuse

2021-02-03 Thread Markus Armbruster
John Snow writes: > _tree_to_qlit is called recursively on dict values alone; at such a > point in generating output it is too late to apply an ifcond. Similarly, > comments do not necessarily have a "tidy" place they can be printed in > such a circumstance. > > Forbid this usage. > > Signed-off-

[PATCH v4 04/14] qapi/introspect.py: guard against ifcond/comment misuse

2021-02-02 Thread John Snow
_tree_to_qlit is called recursively on dict values alone; at such a point in generating output it is too late to apply an ifcond. Similarly, comments do not necessarily have a "tidy" place they can be printed in such a circumstance. Forbid this usage. Signed-off-by: John Snow --- scripts/qapi/i