Re: [PATCH v4 03/28] cpu: Introduce cpu_virtio_is_big_endian()

2021-04-22 Thread Philippe Mathieu-Daudé
Hi Michael, On 3/4/21 8:51 AM, Greg Kurz wrote: > On Wed, 3 Mar 2021 17:08:32 -0500 > "Michael S. Tsirkin" wrote: > >> On Wed, Mar 03, 2021 at 10:46:43PM +0100, Philippe Mathieu-Daudé wrote: >>> Introduce the cpu_virtio_is_big_endian() generic helper to avoid >>> calling CPUClass internal virtio

Re: [PATCH v4 03/28] cpu: Introduce cpu_virtio_is_big_endian()

2021-03-03 Thread Greg Kurz
On Wed, 3 Mar 2021 17:08:32 -0500 "Michael S. Tsirkin" wrote: > On Wed, Mar 03, 2021 at 10:46:43PM +0100, Philippe Mathieu-Daudé wrote: > > Introduce the cpu_virtio_is_big_endian() generic helper to avoid > > calling CPUClass internal virtio_is_big_endian() one. > > > > Signed-off-by: Philippe M

Re: [PATCH v4 03/28] cpu: Introduce cpu_virtio_is_big_endian()

2021-03-03 Thread Richard Henderson
On 3/3/21 2:18 PM, Richard Henderson wrote: On 3/3/21 2:15 PM, Michael S. Tsirkin wrote: On Wed, Mar 03, 2021 at 05:08:36PM -0500, Michael S. Tsirkin wrote: On Wed, Mar 03, 2021 at 10:46:43PM +0100, Philippe Mathieu-Daudé wrote: Introduce the cpu_virtio_is_big_endian() generic helper to avoid

Re: [PATCH v4 03/28] cpu: Introduce cpu_virtio_is_big_endian()

2021-03-03 Thread Richard Henderson
On 3/3/21 2:15 PM, Michael S. Tsirkin wrote: On Wed, Mar 03, 2021 at 05:08:36PM -0500, Michael S. Tsirkin wrote: On Wed, Mar 03, 2021 at 10:46:43PM +0100, Philippe Mathieu-Daudé wrote: Introduce the cpu_virtio_is_big_endian() generic helper to avoid calling CPUClass internal virtio_is_big_endia

Re: [PATCH v4 03/28] cpu: Introduce cpu_virtio_is_big_endian()

2021-03-03 Thread Michael S. Tsirkin
On Wed, Mar 03, 2021 at 05:08:36PM -0500, Michael S. Tsirkin wrote: > On Wed, Mar 03, 2021 at 10:46:43PM +0100, Philippe Mathieu-Daudé wrote: > > Introduce the cpu_virtio_is_big_endian() generic helper to avoid > > calling CPUClass internal virtio_is_big_endian() one. > > > > Signed-off-by: Philip

Re: [PATCH v4 03/28] cpu: Introduce cpu_virtio_is_big_endian()

2021-03-03 Thread Michael S. Tsirkin
On Wed, Mar 03, 2021 at 10:46:43PM +0100, Philippe Mathieu-Daudé wrote: > Introduce the cpu_virtio_is_big_endian() generic helper to avoid > calling CPUClass internal virtio_is_big_endian() one. > > Signed-off-by: Philippe Mathieu-Daudé Using virtio in the name here probably because virtio wants

[PATCH v4 03/28] cpu: Introduce cpu_virtio_is_big_endian()

2021-03-03 Thread Philippe Mathieu-Daudé
Introduce the cpu_virtio_is_big_endian() generic helper to avoid calling CPUClass internal virtio_is_big_endian() one. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 9 + hw/core/cpu.c | 8 ++-- hw/virtio/virtio.c| 4 +--- 3 files changed, 16 insertions