Re: [PATCH v4 03/16] qemu/compiler.h: Add optimize_away

2019-09-24 Thread Richard Henderson
On 9/24/19 12:47 AM, David Hildenbrand wrote: > On 24.09.19 00:59, Richard Henderson wrote: >> +/** >> + * optimize_away() > > I would have used the compiler-speak "optimized_out()" instead. Hmm, that's just a matter of present vs past test. Perhaps, qemu_build_not_reached, to mirror g_assert_no

Re: [PATCH v4 03/16] qemu/compiler.h: Add optimize_away

2019-09-24 Thread David Hildenbrand
On 24.09.19 19:27, Richard Henderson wrote: > On 9/24/19 12:47 AM, David Hildenbrand wrote: >> On 24.09.19 00:59, Richard Henderson wrote: >>> +/** >>> + * optimize_away() >> >> I would have used the compiler-speak "optimized_out()" instead. > > Hmm, that's just a matter of present vs past test. >

Re: [PATCH v4 03/16] qemu/compiler.h: Add optimize_away

2019-09-24 Thread Alex Bennée
Richard Henderson writes: > Use this as a compile-time assert that a particular > code path is not reachable. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/qemu/compiler.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/include/qemu

Re: [PATCH v4 03/16] qemu/compiler.h: Add optimize_away

2019-09-24 Thread David Hildenbrand
On 24.09.19 00:59, Richard Henderson wrote: > Use this as a compile-time assert that a particular > code path is not reachable. > > Signed-off-by: Richard Henderson > --- > include/qemu/compiler.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/include/qemu/compiler.h

[PATCH v4 03/16] qemu/compiler.h: Add optimize_away

2019-09-23 Thread Richard Henderson
Use this as a compile-time assert that a particular code path is not reachable. Signed-off-by: Richard Henderson --- include/qemu/compiler.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 20780e722d..6604ccea92 100644