Re: [PATCH v4 03/12] target/arm: Fix mte_checkN

2021-04-08 Thread Alex Bennée
Peter Maydell writes: > On Wed, 7 Apr 2021 at 19:54, Alex Bennée wrote: >> >> >> Richard Henderson writes: >> >> > We were incorrectly assuming that only the first byte of an MTE access >> > is checked against the tags. But per the ARM, unaligned accesses are >> > pre-decomposed into single-

Re: [PATCH v4 03/12] target/arm: Fix mte_checkN

2021-04-08 Thread Alex Bennée
Richard Henderson writes: > On 4/7/21 11:39 AM, Alex Bennée wrote: >> Richard Henderson writes: >> >>> We were incorrectly assuming that only the first byte of an MTE access >>> is checked against the tags. But per the ARM, unaligned accesses are >>> pre-decomposed into single-byte accesses.

Re: [PATCH v4 03/12] target/arm: Fix mte_checkN

2021-04-08 Thread Peter Maydell
On Wed, 7 Apr 2021 at 19:54, Alex Bennée wrote: > > > Richard Henderson writes: > > > We were incorrectly assuming that only the first byte of an MTE access > > is checked against the tags. But per the ARM, unaligned accesses are > > pre-decomposed into single-byte accesses. So by the time we r

Re: [PATCH v4 03/12] target/arm: Fix mte_checkN

2021-04-07 Thread Richard Henderson
On 4/7/21 11:39 AM, Alex Bennée wrote: Richard Henderson writes: We were incorrectly assuming that only the first byte of an MTE access is checked against the tags. But per the ARM, unaligned accesses are pre-decomposed into single-byte accesses. So by the time we reach the actual MTE check

Re: [PATCH v4 03/12] target/arm: Fix mte_checkN

2021-04-07 Thread Alex Bennée
Richard Henderson writes: > We were incorrectly assuming that only the first byte of an MTE access > is checked against the tags. But per the ARM, unaligned accesses are > pre-decomposed into single-byte accesses. So by the time we reach the > actual MTE check in the ARM pseudocode, all acces

[PATCH v4 03/12] target/arm: Fix mte_checkN

2021-04-06 Thread Richard Henderson
We were incorrectly assuming that only the first byte of an MTE access is checked against the tags. But per the ARM, unaligned accesses are pre-decomposed into single-byte accesses. So by the time we reach the actual MTE check in the ARM pseudocode, all accesses are aligned. Therefore, the first