Re: [PATCH v4 02/23] hw/char/sh_serial: Use hw_error instead of fprintf and abort

2021-10-29 Thread BALATON Zoltan
On Fri, 29 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/28/21 21:27, BALATON Zoltan wrote: It does the same with dumping some more state but avoids calling abort directly and printing to stderr from the device model. hw_error() is unfortunately misnamed, it is meant for CPU code, and we want

Re: [PATCH v4 02/23] hw/char/sh_serial: Use hw_error instead of fprintf and abort

2021-10-28 Thread Thomas Huth
On 29/10/2021 07.38, Philippe Mathieu-Daudé wrote: On 10/28/21 21:27, BALATON Zoltan wrote: It does the same with dumping some more state but avoids calling abort directly and printing to stderr from the device model. hw_error() is unfortunately misnamed, it is meant for CPU code, and we want

Re: [PATCH v4 02/23] hw/char/sh_serial: Use hw_error instead of fprintf and abort

2021-10-28 Thread Philippe Mathieu-Daudé
On 10/28/21 21:27, BALATON Zoltan wrote: > It does the same with dumping some more state but avoids calling abort > directly and printing to stderr from the device model. hw_error() is unfortunately misnamed, it is meant for CPU code, and we want to get ride of it. What you probably want here is e

[PATCH v4 02/23] hw/char/sh_serial: Use hw_error instead of fprintf and abort

2021-10-28 Thread BALATON Zoltan
It does the same with dumping some more state but avoids calling abort directly and printing to stderr from the device model. Signed-off-by: BALATON Zoltan --- hw/char/sh_serial.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial