Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

2020-10-03 Thread Richard Henderson
On 10/3/20 4:15 AM, Paolo Bonzini wrote: > On 03/10/20 11:13, Richard Henderson wrote: >>> +target_kconfig = 'target' / config_target['TARGET_BASE_ARCH'] / >>> 'Kconfig' >>> +minikconf_input = ['default-configs' / target + '.mak', 'Kconfig'] >>> +if fs.is_file(target_kconfig) >> Missin

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

2020-10-03 Thread Paolo Bonzini
On 03/10/20 11:13, Richard Henderson wrote: >> +target_kconfig = 'target' / config_target['TARGET_BASE_ARCH'] / >> 'Kconfig' >> +minikconf_input = ['default-configs' / target + '.mak', 'Kconfig'] >> +if fs.is_file(target_kconfig) > Missing a meson.current_source_dir()? > Leastwise that

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

2020-10-03 Thread Richard Henderson
On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote: > +++ b/meson.build > @@ -529,6 +529,7 @@ kconfig_external_symbols = [ > ] > ignored = ['TARGET_XML_FILES', 'TARGET_ABI_DIR', 'TARGET_DIRS'] > > +fs = import('fs') Note that I have this in the capstone update, and I placed it closer to the top

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

2020-09-30 Thread Paolo Bonzini
On 30/09/20 14:50, Claudio Fontana wrote: > On 9/30/20 12:43 AM, Philippe Mathieu-Daudé wrote: >> Extend the generic Meson script to pass optional target Kconfig >> file to the minikconf script. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> We could use fs.exists() but is_file() is more sp

Re: [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

2020-09-30 Thread Claudio Fontana
On 9/30/20 12:43 AM, Philippe Mathieu-Daudé wrote: > Extend the generic Meson script to pass optional target Kconfig > file to the minikconf script. > > Signed-off-by: Philippe Mathieu-Daudé > --- > We could use fs.exists() but is_file() is more specific > (can not be a directory). > > Cc: Paolo

[PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig

2020-09-29 Thread Philippe Mathieu-Daudé
Extend the generic Meson script to pass optional target Kconfig file to the minikconf script. Signed-off-by: Philippe Mathieu-Daudé --- We could use fs.exists() but is_file() is more specific (can not be a directory). Cc: Paolo Bonzini Cc: Claudio Fontana --- meson.build | 8 +++- 1 file