Re: [PATCH v4 01/16] block: refactor bdrv_check_request: add errp

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > It's better to pass &error_abort than just assert that result is 0: on > crash, we'll immediately see the reason in the backtrace. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block_int.h| 2 +- > block/fil

Re: [PATCH v4 01/16] block: refactor bdrv_check_request: add errp

2021-01-20 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > It's better to pass &error_abort than just assert that result is 0: on > crash, we'll immediately see the reason in the backtrace. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block_int.h| 2 +- > block/fil

[PATCH v4 01/16] block: refactor bdrv_check_request: add errp

2020-12-11 Thread Vladimir Sementsov-Ogievskiy
It's better to pass &error_abort than just assert that result is 0: on crash, we'll immediately see the reason in the backtrace. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h| 2 +- block/file-posix.c | 2 +- block/io.c | 29 +