Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

Hi Still trying to make progress on this series (which is preliminary to other pending work..): On Wed, Dec 11, 2019 at 4:01 PM Marc-André Lureau wrote: > > Hi > > On Sun, Dec 1, 2019 at 2:19 PM Marc-André Lureau > wrote: > > > > > > - "chardev: generate an internal id when none given" > > > >

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

Hi Marc-André, On 12/11/19 1:01 PM, Marc-André Lureau wrote: Hi On Sun, Dec 1, 2019 at 2:19 PM Marc-André Lureau wrote: - "chardev: generate an internal id when none given" As explained, this is necessary for qdev_prop_set_chr() ping - "serial: register vmsd with DeviceClass" This is

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

Hi On Fri, Dec 13, 2019 at 12:18 AM Dr. David Alan Gilbert wrote: > > Apologies for the delay. > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Sun, Dec 1, 2019 at 10:10 PM Peter Maydell > > wrote: > > > > > > On Sun, 1 Dec 2019 at 17:27, Marc-André Lureau > > > wr

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

Apologies for the delay. * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Sun, Dec 1, 2019 at 10:10 PM Peter Maydell > wrote: > > > > On Sun, 1 Dec 2019 at 17:27, Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Sun, Dec 1, 2019 at 9:18 PM Peter Maydell > > > wro

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

Hi On Sun, Dec 1, 2019 at 2:19 PM Marc-André Lureau wrote: > > > - "chardev: generate an internal id when none given" > > As explained, this is necessary for qdev_prop_set_chr() ping > > - "serial: register vmsd with DeviceClass" > > This is standard qdev-ification, however it breaks backward m

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

Hi On Sun, Dec 1, 2019 at 10:10 PM Peter Maydell wrote: > > On Sun, 1 Dec 2019 at 17:27, Marc-André Lureau > wrote: > > > > Hi > > > > On Sun, Dec 1, 2019 at 9:18 PM Peter Maydell > > wrote: > > > > > > On Sun, 1 Dec 2019 at 10:19, Marc-André Lureau > > > wrote: > > > > > > > > - "serial: reg

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

On Sun, 1 Dec 2019 at 17:27, Marc-André Lureau wrote: > > Hi > > On Sun, Dec 1, 2019 at 9:18 PM Peter Maydell wrote: > > > > On Sun, 1 Dec 2019 at 10:19, Marc-André Lureau > > wrote: > > > > > > - "serial: register vmsd with DeviceClass" > > > > > > This is standard qdev-ification, however it br

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

Hi On Sun, Dec 1, 2019 at 9:18 PM Peter Maydell wrote: > > On Sun, 1 Dec 2019 at 10:19, Marc-André Lureau > wrote: > > > > - "serial: register vmsd with DeviceClass" > > > > This is standard qdev-ification, however it breaks backward migration, > > but that's just how qdev_set_legacy_instance_id

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

On Sun, 1 Dec 2019 at 10:19, Marc-André Lureau wrote: > > - "serial: register vmsd with DeviceClass" > > This is standard qdev-ification, however it breaks backward migration, > but that's just how qdev_set_legacy_instance_id() works. I don't understand this part. Surely the whole point of settin

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

Hi On Wed, Nov 20, 2019 at 7:25 PM Marc-André Lureau wrote: > > Hi, > > QDEV_PROP_PTR is marked in multiple places as "FIXME/TODO/remove > me". In most cases, it can be easily replaced with QDEV_PROP_LINK when > the pointer points to an Object. > > There are a few places where such substitution i

[PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

Hi, QDEV_PROP_PTR is marked in multiple places as "FIXME/TODO/remove me". In most cases, it can be easily replaced with QDEV_PROP_LINK when the pointer points to an Object. There are a few places where such substitution isn't possible. For those places, it seems reasonable to use a specific sette