Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-11 Thread Richard Henderson
On 3/11/21 8:03 AM, David Hildenbrand wrote: As talked with Thomas off-list, there is no trusting on host==NULL as well (see comment in struct S390Access). host==NULL simply means we have to do individual ld/st. I think that comment is stale with the use of probe_access instead of tlb_vaddr_to

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-11 Thread David Hildenbrand
On 11.03.21 16:58, Richard Henderson wrote: On 3/11/21 8:03 AM, David Hildenbrand wrote: As talked with Thomas off-list, there is no trusting on host==NULL as well (see comment in struct S390Access). host==NULL simply means we have to do individual ld/st. I think that comment is stale with the

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-11 Thread David Hildenbrand
On 03.03.21 14:28, Thomas Huth wrote: From: Richard Henderson If the CCO bit is set, MVPG should not generate an exception but report page translation faults via a CC code. Create a new helper, access_prepare_nf, which can use probe_access_flags in non-faulting mode, and then handle watchpoint

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-11 Thread Cornelia Huck
On Wed, 10 Mar 2021 21:49:22 +0100 David Hildenbrand wrote: > > Am 09.03.2021 um 22:05 schrieb Thomas Huth : > > > > On 04/03/2021 09.10, David Hildenbrand wrote: > >>> On 03.03.21 22:36, Richard Henderson wrote: > >>> On 3/3/21 1:22 PM, David Hildenbrand wrote: > > > Am 03.03.2

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-10 Thread David Hildenbrand
> Am 09.03.2021 um 22:05 schrieb Thomas Huth : > > On 04/03/2021 09.10, David Hildenbrand wrote: >>> On 03.03.21 22:36, Richard Henderson wrote: >>> On 3/3/21 1:22 PM, David Hildenbrand wrote: > Am 03.03.2021 um 22:19 schrieb Richard Henderson > : > > On 3/3/21 1:11 PM,

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-09 Thread Thomas Huth
On 04/03/2021 09.10, David Hildenbrand wrote: On 03.03.21 22:36, Richard Henderson wrote: On 3/3/21 1:22 PM, David Hildenbrand wrote: Am 03.03.2021 um 22:19 schrieb Richard Henderson : On 3/3/21 1:11 PM, David Hildenbrand wrote: MMIO on s390x? :) hw/s390x/s390-pci-bus.c, memory_region_i

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-04 Thread Cornelia Huck
On Thu, 4 Mar 2021 09:10:44 +0100 David Hildenbrand wrote: > On 03.03.21 22:36, Richard Henderson wrote: > > On 3/3/21 1:22 PM, David Hildenbrand wrote: > >> > >>> Am 03.03.2021 um 22:19 schrieb Richard Henderson > >>> : > >>> > >>> On 3/3/21 1:11 PM, David Hildenbrand wrote: > MMIO

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-04 Thread David Hildenbrand
On 03.03.21 22:36, Richard Henderson wrote: On 3/3/21 1:22 PM, David Hildenbrand wrote: Am 03.03.2021 um 22:19 schrieb Richard Henderson : On 3/3/21 1:11 PM, David Hildenbrand wrote: MMIO on s390x? :) hw/s390x/s390-pci-bus.c, memory_region_init_io*(). ... part of system address space w

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-03 Thread Richard Henderson
On 3/3/21 1:22 PM, David Hildenbrand wrote: Am 03.03.2021 um 22:19 schrieb Richard Henderson : On 3/3/21 1:11 PM, David Hildenbrand wrote: MMIO on s390x? :) hw/s390x/s390-pci-bus.c, memory_region_init_io*(). ... part of system address space where a CPU could stumble over it? Impossibl

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-03 Thread David Hildenbrand
> Am 03.03.2021 um 22:19 schrieb Richard Henderson > : > > On 3/3/21 1:11 PM, David Hildenbrand wrote: >> MMIO on s390x? :) > > hw/s390x/s390-pci-bus.c, memory_region_init_io*(). > ... part of system address space where a CPU could stumble over it? > r~ >

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-03 Thread Richard Henderson
On 3/3/21 1:11 PM, David Hildenbrand wrote: MMIO on s390x? :) hw/s390x/s390-pci-bus.c, memory_region_init_io*(). r~

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-03 Thread David Hildenbrand
> Am 03.03.2021 um 22:05 schrieb Richard Henderson > : > > On 3/3/21 11:39 AM, David Hildenbrand wrote: >> Should we start wrapping that stuff into #ifdef CONFIG_TCG ? >>> +uint64_t tlb_fill_tec; /* translation exception code during tlb_fill >>> */ >>> +int tlb_fill_exc;/* e

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-03 Thread Richard Henderson
On 3/3/21 11:39 AM, David Hildenbrand wrote: Should we start wrapping that stuff into #ifdef CONFIG_TCG ? +    uint64_t tlb_fill_tec;   /* translation exception code during tlb_fill */ +    int tlb_fill_exc;    /* exception number seen during tlb_fill */ Eh, probably not. At least not un

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-03 Thread David Hildenbrand
On 03.03.21 14:28, Thomas Huth wrote: From: Richard Henderson If the CCO bit is set, MVPG should not generate an exception but report page translation faults via a CC code. Create a new helper, access_prepare_nf, which can use probe_access_flags in non-faulting mode, and then handle watchpoint

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-03 Thread Richard Henderson
On 3/3/21 5:28 AM, Thomas Huth wrote: From: Richard Henderson If the CCO bit is set, MVPG should not generate an exception but report page translation faults via a CC code. Create a new helper, access_prepare_nf, which can use probe_access_flags in non-faulting mode, and then handle watchpoints

[PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-03 Thread Thomas Huth
From: Richard Henderson If the CCO bit is set, MVPG should not generate an exception but report page translation faults via a CC code. Create a new helper, access_prepare_nf, which can use probe_access_flags in non-faulting mode, and then handle watchpoints. Signed-off-by: Richard Henderson [t