Re: [PATCH v4] hw/i386/pc: add max combined fw size as machine configuration option

2020-09-25 Thread Gerd Hoffmann
Hi, > > +pcms->max_fw_size = 8 * MiB; /* use default */ [ ... ] > All I'm saying is that the "/* use default */" comment should not be > copied from "max_ram_below_4g" to "max_fw_size", because the (assumed) > meaning of the original comment does not apply to the new field. Fully agree.

Re: [PATCH v4] hw/i386/pc: add max combined fw size as machine configuration option

2020-09-24 Thread Laszlo Ersek
On 09/23/20 15:18, Erich Mcmillan wrote: > From: Erich McMillan > > At HPi we have a need for increased fw size to enable testing of our custom > fw. > > Signed-off-by: Erich McMillan > --- > hw/i386/pc.c | 50 > hw/i386/pc_sysfw.c | 13 +

[PATCH v4] hw/i386/pc: add max combined fw size as machine configuration option

2020-09-23 Thread Erich Mcmillan
From: Erich McMillan At HPi we have a need for increased fw size to enable testing of our custom fw. Signed-off-by: Erich McMillan --- hw/i386/pc.c | 50 hw/i386/pc_sysfw.c | 13 ++-- include/hw/i386/pc.h | 2 ++ 3 files changed,