Re: [PATCH v4] hw/i386/cpu: remove default_cpu_version and simplify

2025-01-23 Thread Ani Sinha
On Thu, Jan 23, 2025 at 1:56 PM Zhao Liu wrote: > > Hi Ani, > > [snip] > > > --- a/include/hw/i386/x86.h > > +++ b/include/hw/i386/x86.h > > @@ -114,7 +114,10 @@ void init_topo_info(X86CPUTopoInfo *topo_info, const > > X86MachineState *x86ms); > > uint32_t x86_cpu_apic_id_from_index(X86MachineSt

Re: [PATCH v4] hw/i386/cpu: remove default_cpu_version and simplify

2025-01-23 Thread Zhao Liu
Hi Ani, [snip] > --- a/include/hw/i386/x86.h > +++ b/include/hw/i386/x86.h > @@ -114,7 +114,10 @@ void init_topo_info(X86CPUTopoInfo *topo_info, const > X86MachineState *x86ms); > uint32_t x86_cpu_apic_id_from_index(X86MachineState *x86ms, > unsigned int cpu

[PATCH v4] hw/i386/cpu: remove default_cpu_version and simplify

2025-01-22 Thread Ani Sinha
commit 0788a56bd1ae3 ("i386: Make unversioned CPU models be aliases") introduced 'default_cpu_version' for PCMachineClass. This created three categories of CPU models: - Most unversioned CPU models would use version 1 by default. - For machines 4.0.1 and older that do not support cpu model aliase