Re: [PATCH v4] cxl-cdat:Fix open file not closed in ct3_load_cdat

2023-04-13 Thread Hao Zeng
On Thu, 2023-04-13 at 12:17 +0100, Jonathan Cameron wrote: > On Thu, 13 Apr 2023 17:33:28 +0800 > Hao Zeng wrote: > > > opened file processor not closed,May cause file processor leaks > > Patch description needs to say more on how this is fixed. > Perhaps something like: > "Open file descriptor

Re: [PATCH v4] cxl-cdat:Fix open file not closed in ct3_load_cdat

2023-04-13 Thread Hao Zeng
On Thu, 2023-04-13 at 12:17 +0100, Jonathan Cameron wrote: > On Thu, 13 Apr 2023 17:33:28 +0800 > Hao Zeng wrote: > > > opened file processor not closed,May cause file processor leaks > > Patch description needs to say more on how this is fixed. > Perhaps something like: > "Open file descriptor

Re: [PATCH v4] cxl-cdat:Fix open file not closed in ct3_load_cdat

2023-04-13 Thread Jonathan Cameron via
On Thu, 13 Apr 2023 17:33:28 +0800 Hao Zeng wrote: > opened file processor not closed,May cause file processor leaks Patch description needs to say more on how this is fixed. Perhaps something like: "Open file descriptor not closed in error paths. Fix by replace open coded handling of read of w

[PATCH v4] cxl-cdat:Fix open file not closed in ct3_load_cdat

2023-04-13 Thread Hao Zeng
opened file processor not closed,May cause file processor leaks Fixes: aba578bdac ("hw/cxl: CDAT Data Object Exchange implementation") Signed-off-by: Zeng Hao Suggested-by: Philippe Mathieu-Daudé Suggested-by: Peter Maydell --- ChangeLog: v3-v4: Modify commit information,No code