Re: [PATCH v3 for-5.2 3/3] spapr/xive: Convert KVM device fd checks to assert()

2020-08-13 Thread David Gibson
On Fri, Aug 07, 2020 at 01:32:21PM +0200, Greg Kurz wrote: > All callers guard these functions with an xive_in_kernel() helper. Make > it clear that they are only to be called when the KVM XIVE device exists. > > Note that the check on xive is dropped in kvmppc_xive_disconnect(). It > really canno

Re: [PATCH v3 for-5.2 3/3] spapr/xive: Convert KVM device fd checks to assert()

2020-08-07 Thread Cédric Le Goater
On 8/7/20 1:32 PM, Greg Kurz wrote: > All callers guard these functions with an xive_in_kernel() helper. Make > it clear that they are only to be called when the KVM XIVE device exists. > > Note that the check on xive is dropped in kvmppc_xive_disconnect(). It > really cannot be NULL since it come

[PATCH v3 for-5.2 3/3] spapr/xive: Convert KVM device fd checks to assert()

2020-08-07 Thread Greg Kurz
All callers guard these functions with an xive_in_kernel() helper. Make it clear that they are only to be called when the KVM XIVE device exists. Note that the check on xive is dropped in kvmppc_xive_disconnect(). It really cannot be NULL since it comes from set_active_intc() which only passes poi