Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-07-10 Thread Thomas Huth
On 10/07/2023 11.35, Daniel P. Berrangé wrote: On Thu, Jun 01, 2023 at 07:43:43PM -0400, Peter Xu wrote: On Fri, Jun 02, 2023 at 01:00:10AM +0200, Juan Quintela wrote: That was basically my idea and that is why I am holding the last two patches and see if I can came with something in the next c

Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-07-10 Thread Daniel P . Berrangé
On Thu, Jun 01, 2023 at 07:43:43PM -0400, Peter Xu wrote: > On Fri, Jun 02, 2023 at 01:00:10AM +0200, Juan Quintela wrote: > > That was basically my idea and that is why I am holding the last two > > patches and see if I can came with something in the next couple of days. > > Ah! ... > > If you h

Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-06-01 Thread Peter Xu
On Fri, Jun 02, 2023 at 01:00:10AM +0200, Juan Quintela wrote: > That was basically my idea and that is why I am holding the last two > patches and see if I can came with something in the next couple of days. Ah! ... If you haven't started, please hold off for one day. I'll see whether I can pos

Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-06-01 Thread Juan Quintela
Peter Xu wrote: > On Wed, May 31, 2023 at 02:24:00PM +0100, Daniel P. Berrangé wrote: >> The migration test cases that actually exercise live migration want to >> ensure there is a minimum of two iterations of pre-copy, in order to >> exercise the dirty tracking code. >> >> Historically we've que

Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-06-01 Thread Peter Xu
On Thu, Jun 01, 2023 at 05:36:42PM +0100, Daniel P. Berrangé wrote: > > The problem is non-live is already not real world usage in most cases. It > > seems we all agreed that it's the code paths to cover not real world usages > > in the tests, or maybe not? > > The cases that i made run non-live

Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-06-01 Thread Daniel P . Berrangé
On Thu, Jun 01, 2023 at 12:22:36PM -0400, Peter Xu wrote: > On Thu, Jun 01, 2023 at 05:05:23PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 01, 2023 at 11:46:01AM -0400, Peter Xu wrote: > > > On Wed, May 31, 2023 at 02:24:00PM +0100, Daniel P. Berrangé wrote: > > > > The migration test cases th

Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-06-01 Thread Peter Xu
On Thu, Jun 01, 2023 at 05:05:23PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 01, 2023 at 11:46:01AM -0400, Peter Xu wrote: > > On Wed, May 31, 2023 at 02:24:00PM +0100, Daniel P. Berrangé wrote: > > > The migration test cases that actually exercise live migration want to > > > ensure there is

Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-06-01 Thread Daniel P . Berrangé
On Thu, Jun 01, 2023 at 11:46:01AM -0400, Peter Xu wrote: > On Wed, May 31, 2023 at 02:24:00PM +0100, Daniel P. Berrangé wrote: > > The migration test cases that actually exercise live migration want to > > ensure there is a minimum of two iterations of pre-copy, in order to > > exercise the dirty

Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-06-01 Thread Peter Xu
On Wed, May 31, 2023 at 02:24:00PM +0100, Daniel P. Berrangé wrote: > The migration test cases that actually exercise live migration want to > ensure there is a minimum of two iterations of pre-copy, in order to > exercise the dirty tracking code. > > Historically we've queried the migration statu

Re: [PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-06-01 Thread Thomas Huth
On 31/05/2023 15.24, Daniel P. Berrangé wrote: The migration test cases that actually exercise live migration want to ensure there is a minimum of two iterations of pre-copy, in order to exercise the dirty tracking code. Historically we've queried the migration status, looking for the 'dirty-syn

[PATCH v3 9/9] tests/qtest: massively speed up migration-test

2023-05-31 Thread Daniel P . Berrangé
The migration test cases that actually exercise live migration want to ensure there is a minimum of two iterations of pre-copy, in order to exercise the dirty tracking code. Historically we've queried the migration status, looking for the 'dirty-sync-count' value to increment to track iterations.