Re: [PATCH v3 7/9] hw/pci-host/pam: Make init_pam() usage more readable

2023-02-05 Thread Philippe Mathieu-Daudé
On 4/2/23 16:10, Bernhard Beschow wrote: Unlike pam_update() which takes the subject -- PAMMemoryRegion -- as first argument, init_pam() takes it as fifth (!) argument. This makes it quite hard to figure out what an init_pam() invocation actually initializes. By moving the subject to the front th

[PATCH v3 7/9] hw/pci-host/pam: Make init_pam() usage more readable

2023-02-04 Thread Bernhard Beschow
Unlike pam_update() which takes the subject -- PAMMemoryRegion -- as first argument, init_pam() takes it as fifth (!) argument. This makes it quite hard to figure out what an init_pam() invocation actually initializes. By moving the subject to the front this should become clearer. While at it, low