Re: [PATCH v3 5/7] hw/misc/mps2-fpgaio: Use the LED device

2020-06-21 Thread Philippe Mathieu-Daudé
On 6/21/20 11:00 PM, Richard Henderson wrote: > On 6/20/20 4:07 PM, Philippe Mathieu-Daudé wrote: >> +DeviceState *led[2]; > > Perhaps better as LEDState? And perhaps return that from create_led. I guess I first thought about using an opaque structure with forward typedef declaration, but in

Re: [PATCH v3 5/7] hw/misc/mps2-fpgaio: Use the LED device

2020-06-21 Thread Richard Henderson
On 6/20/20 4:07 PM, Philippe Mathieu-Daudé wrote: > +DeviceState *led[2]; Perhaps better as LEDState? And perhaps return that from create_led. r~

[PATCH v3 5/7] hw/misc/mps2-fpgaio: Use the LED device

2020-06-20 Thread Philippe Mathieu-Daudé
Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical Reference Manual' (100112_0200_07_en): 2.1 Overview of the MPS2 and MPS2+ hardware The MPS2 and MPS2+ FPGA Prototyping Boards contain the following components and interfaces: * User switches and user LEDs: