Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

2024-12-20 Thread Philippe Mathieu-Daudé
On 20/12/24 22:08, Michael Tokarev wrote: 13.08.2024 18:10, Philippe Mathieu-Daudé wrote: Has this change been forgotten, or is it not appropriate anymore? Not forgotten and still need to be fixed, however unfortunately this exposed a bug in user-mode SYS_exit_group when using plugins (see qe

Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

2024-12-20 Thread Michael Tokarev
13.08.2024 18:10, Philippe Mathieu-Daudé wrote: Has this change been forgotten, or is it not appropriate anymore? Not forgotten and still need to be fixed, however unfortunately this exposed a bug in user-mode SYS_exit_group when using plugins (see qemu_plugin_disable_mem_helpers call in qemu_

Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

2024-08-13 Thread Philippe Mathieu-Daudé
Hi Michael, On 11/8/24 19:43, Michael Tokarev wrote: 03.05.2024 15:34, Philippe Mathieu-Daudé wrote: In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out") we unfortunately restricted the tcg_flush_jmp_cache() to system emulation. Move it to the common tcg_exec_cpu_reset_hold() han

Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

2024-08-11 Thread Michael Tokarev
03.05.2024 15:34, Philippe Mathieu-Daudé wrote: In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out") we unfortunately restricted the tcg_flush_jmp_cache() to system emulation. Move it to the common tcg_exec_cpu_reset_hold() handler so user emulation gets the jmp_cache initialized w

Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

2024-05-16 Thread Fiona Ebner
Hi, Am 03.05.24 um 14:34 schrieb Philippe Mathieu-Daudé: > In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out") > we unfortunately restricted the tcg_flush_jmp_cache() to system > emulation. Move it to the common tcg_exec_cpu_reset_hold() handler > so user emulation gets the jmp_cac

[PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

2024-05-03 Thread Philippe Mathieu-Daudé
In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out") we unfortunately restricted the tcg_flush_jmp_cache() to system emulation. Move it to the common tcg_exec_cpu_reset_hold() handler so user emulation gets the jmp_cache initialized when threads are created. Remove the NULL check in