Re: [PATCH v3 4/8] migration: Drop migration_is_setup_or_active()

2024-10-29 Thread Fabiano Rosas
Peter Xu writes: > This helper is mostly the same as migration_is_running(), except that one > has COLO reported as true, the other has CANCELLING reported as true. > > Per my past years experience on the state changes, none of them should > matter. > > To make it slightly safer, report both COLO

Re: [PATCH v3 4/8] migration: Drop migration_is_setup_or_active()

2024-10-25 Thread Cédric Le Goater
On 10/24/24 23:30, Peter Xu wrote: This helper is mostly the same as migration_is_running(), except that one has COLO reported as true, the other has CANCELLING reported as true. Per my past years experience on the state changes, none of them should matter. To make it slightly safer, report bot

[PATCH v3 4/8] migration: Drop migration_is_setup_or_active()

2024-10-25 Thread Peter Xu
This helper is mostly the same as migration_is_running(), except that one has COLO reported as true, the other has CANCELLING reported as true. Per my past years experience on the state changes, none of them should matter. To make it slightly safer, report both COLO || CANCELLING to be true in mi