Re: [PATCH v3 4/5] hw/misc: Add a PWM module for NPCM7XX

2020-12-16 Thread Hao Wu via
Thanks for the review. We can add a patch in this patchset to fix this issue. On Wed, Dec 16, 2020 at 11:02 AM Peter Maydell wrote: > On Tue, 15 Dec 2020 at 00:13, Hao Wu wrote: > > > > The PWM module is part of NPCM7XX module. Each NPCM7XX module has two > > identical PWM modules. Each module

Re: [PATCH v3 4/5] hw/misc: Add a PWM module for NPCM7XX

2020-12-16 Thread Peter Maydell
On Tue, 15 Dec 2020 at 00:13, Hao Wu wrote: > > The PWM module is part of NPCM7XX module. Each NPCM7XX module has two > identical PWM modules. Each module contains 4 PWM entries. Each PWM has > two outputs: frequency and duty_cycle. Both are computed using inputs > from software side. > > This mod

Re: [PATCH v3 4/5] hw/misc: Add a PWM module for NPCM7XX

2020-12-14 Thread Hao Wu via
On Mon, Dec 14, 2020 at 4:13 PM Hao Wu wrote: > The PWM module is part of NPCM7XX module. Each NPCM7XX module has two > identical PWM modules. Each module contains 4 PWM entries. Each PWM has > two outputs: frequency and duty_cycle. Both are computed using inputs > from software side. > > This mo

[PATCH v3 4/5] hw/misc: Add a PWM module for NPCM7XX

2020-12-14 Thread Hao Wu via
The PWM module is part of NPCM7XX module. Each NPCM7XX module has two identical PWM modules. Each module contains 4 PWM entries. Each PWM has two outputs: frequency and duty_cycle. Both are computed using inputs from software side. This module does not model detail pulse signals since it is expens