Re: [PATCH v3 39/42] target/arm: Don't shift attrs in get_phys_addr_lpae

2022-10-07 Thread Peter Maydell
On Sat, 1 Oct 2022 at 17:49, Richard Henderson wrote: > > Leave the upper and lower attributes in the place they originate > from in the descriptor. Shifting them around is confusing, since > one cannot read the bit numbers out of the manual. Also, new > attributes have been added which would al

[PATCH v3 39/42] target/arm: Don't shift attrs in get_phys_addr_lpae

2022-10-01 Thread Richard Henderson
Leave the upper and lower attributes in the place they originate from in the descriptor. Shifting them around is confusing, since one cannot read the bit numbers out of the manual. Also, new attributes have been added which would alter the shifts. Signed-off-by: Richard Henderson --- target/ar