Re: [PATCH v3 3/7] arm/virt: Use virtio-md-pci (un)plug functions

2023-07-11 Thread David Hildenbrand
On 11.07.23 11:22, David Hildenbrand wrote: On 11.07.23 10:47, Michael S. Tsirkin wrote: On Tue, Jul 11, 2023 at 10:32:31AM +0200, David Hildenbrand wrote: On 10.07.23 23:40, Michael S. Tsirkin wrote: @@ -2855,12 +2796,11 @@ static void virt_machine_device_plug_cb(HotplugHandler *hotplug_dev,

Re: [PATCH v3 3/7] arm/virt: Use virtio-md-pci (un)plug functions

2023-07-11 Thread David Hildenbrand
On 11.07.23 10:47, Michael S. Tsirkin wrote: On Tue, Jul 11, 2023 at 10:32:31AM +0200, David Hildenbrand wrote: On 10.07.23 23:40, Michael S. Tsirkin wrote: @@ -2855,12 +2796,11 @@ static void virt_machine_device_plug_cb(HotplugHandler *hotplug_dev, SYS_

Re: [PATCH v3 3/7] arm/virt: Use virtio-md-pci (un)plug functions

2023-07-11 Thread Michael S. Tsirkin
On Tue, Jul 11, 2023 at 10:32:31AM +0200, David Hildenbrand wrote: > On 10.07.23 23:40, Michael S. Tsirkin wrote: > > > @@ -2855,12 +2796,11 @@ static void > > > virt_machine_device_plug_cb(HotplugHandler *hotplug_dev, > > >SYS_BUS_DEVICE(dev)); > > >

Re: [PATCH v3 3/7] arm/virt: Use virtio-md-pci (un)plug functions

2023-07-11 Thread David Hildenbrand
On 10.07.23 23:40, Michael S. Tsirkin wrote: On Mon, Jul 10, 2023 at 12:07:10PM +0200, David Hildenbrand wrote: Let's use our new helper functions. Note that virtio-pmem-pci is not enabled for arm and, therefore, not compiled in. Signed-off-by: David Hildenbrand --- hw/arm/virt.c | 81 ++

Re: [PATCH v3 3/7] arm/virt: Use virtio-md-pci (un)plug functions

2023-07-10 Thread Michael S. Tsirkin
On Mon, Jul 10, 2023 at 12:07:10PM +0200, David Hildenbrand wrote: > Let's use our new helper functions. Note that virtio-pmem-pci is not > enabled for arm and, therefore, not compiled in. > > Signed-off-by: David Hildenbrand > --- > hw/arm/virt.c | 81 ---

[PATCH v3 3/7] arm/virt: Use virtio-md-pci (un)plug functions

2023-07-10 Thread David Hildenbrand
Let's use our new helper functions. Note that virtio-pmem-pci is not enabled for arm and, therefore, not compiled in. Signed-off-by: David Hildenbrand --- hw/arm/virt.c | 81 --- 1 file changed, 12 insertions(+), 69 deletions(-) diff --git a/hw/ar